From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH 1/6] vfs: Move noop_backing_dev_info check from sync into
 writeback
Date: Thu, 20 Oct 2011 05:48:59 -0400
Message-ID: <20111020094859.GB11291@infradead.org>
References: <1318020055-4450-1-git-send-email-jack@suse.cz>
 <1318020055-4450-2-git-send-email-jack@suse.cz>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@infradead.org>,
	Curt Wohlgemuth <curtw@google.com>,
	linux-fsdevel@vger.kernel.org, Al Viro <viro@ZenIV.linux.org.uk>
To: Jan Kara <jack@suse.cz>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:43463
	"EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1754682Ab1JTJtD (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Thu, 20 Oct 2011 05:49:03 -0400
Content-Disposition: inline
In-Reply-To: <1318020055-4450-2-git-send-email-jack@suse.cz>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Oct 07, 2011 at 10:40:50PM +0200, Jan Kara wrote:
> In principle, a filesystem may want to have ->sync_fs() called during sync(1)
> although it does not have a bdi (i.e. s_bdi is set to noop_backing_dev_info).
> Only writeback code really needs bdi set to something reasonable. So move the
> checks where they are more logical.

Looks good, but the comment above the check isn't too useful.  Either
remove it or write something more substancial.

Reviewed-by: Christoph Hellwig <hch@lst.de>