From: Christoph Hellwig <hch@infradead.org>
To: Dmitry Monakhov <dmonakhov@openvz.org>
Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
linux-ext4@vger.kernel.org, jack@suse.cz, hch@infradead.org,
aelder@sgi.com
Subject: Re: [PATCH 1/8] xfstests: fsstress should kill children tasks before exit
Date: Mon, 24 Oct 2011 05:06:45 -0400 [thread overview]
Message-ID: <20111024090645.GA31887@infradead.org> (raw)
In-Reply-To: <1319020189-13584-2-git-send-email-dmonakhov@openvz.org>
> +int should_stop = 0;
this should use sig_atomic_t, or at least volatile.
>
> void add_to_flist(int, int, int);
> void append_pathname(pathname_t *, char *);
> @@ -253,6 +256,10 @@ void usage(void);
> void write_freq(void);
> void zero_freq(void);
>
> +void sg_handler(int signum) {
> + should_stop = 1;
> +}
please use normal K&R / Linux style brace placement.
next prev parent reply other threads:[~2011-10-24 9:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-19 10:29 [PATCH 0/8] xfstests: Bunch of new tests Dmitry Monakhov
2011-10-19 10:29 ` [PATCH 1/8] xfstests: fsstress should kill children tasks before exit Dmitry Monakhov
2011-10-24 9:06 ` Christoph Hellwig [this message]
2011-10-19 10:29 ` [PATCH 2/8] xfstests: add different logging option to fsstress Dmitry Monakhov
2011-10-24 9:15 ` Christoph Hellwig
2011-10-19 10:29 ` [PATCH 3/8] xfstests: add fallocate support " Dmitry Monakhov
2011-10-19 10:29 ` [PATCH 4/8] xfstests: fsstress add FS_IOC_{SET,GET}FLAGS operations Dmitry Monakhov
2011-10-19 10:29 ` [PATCH 5/8] xfstests: Dump inode info when possible Dmitry Monakhov
2011-10-24 9:16 ` Christoph Hellwig
2011-10-19 10:29 ` [PATCH 6/8] xfstests: add fiemap operation Dmitry Monakhov
2011-10-19 10:29 ` [PATCH 7/8] xfstests: add new stress test Dmitry Monakhov
2011-10-24 9:08 ` Christoph Hellwig
2011-10-19 10:29 ` [PATCH 8/8] xfstests: add new quota " Dmitry Monakhov
2011-10-24 9:14 ` Christoph Hellwig
2011-10-20 9:40 ` new corruption pattern on ext4 Dmitry Monakhov
2011-10-20 20:38 ` [PATCH] xfstests: add regression test for extent corruption " Dmitry Monakhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111024090645.GA31887@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=dmonakhov@openvz.org \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).