From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dave Chinner Subject: Re: [PATCH 1/9] xfstests: fsstress add command line style output for show_opts Date: Tue, 8 Nov 2011 07:52:50 +1100 Message-ID: <20111107205250.GG5534@dastard> References: <1320342953-7973-1-git-send-email-dmonakhov@openvz.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com, hch@lst.de, aelder@sgi.com, tytso@mit.edu To: Dmitry Monakhov Return-path: Received: from ipmail05.adl6.internode.on.net ([150.101.137.143]:45400 "EHLO ipmail05.adl6.internode.on.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752576Ab1KGUwy (ORCPT ); Mon, 7 Nov 2011 15:52:54 -0500 Content-Disposition: inline In-Reply-To: <1320342953-7973-1-git-send-email-dmonakhov@openvz.org> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Thu, Nov 03, 2011 at 09:55:45PM +0400, Dmitry Monakhov wrote: > Once some combination of seed+fs_ops result in regression it is > reasonable to document that combination. It is usefull to dump > that configuration in command line style. Later this line may be > simply hardcoded in to regression test. ..... > @@ -345,7 +345,10 @@ int main(int argc, char **argv) > zero_freq(); > break; > case 'S': > - show_ops(0, NULL); > + i = 0; > + if (optarg[0] == 'c') > + i = 1; > + show_ops(1, NULL); I don't think that does what it is supposed to do... Cheers, Dave. -- Dave Chinner david@fromorbit.com