From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 0/2] Make task doing heavy writing killable Date: Mon, 14 Nov 2011 10:32:26 -0500 Message-ID: <20111114153226.GA4308@infradead.org> References: <1321269030-6019-1-git-send-email-jack@suse.cz> <20111114115912.GA3224@localhost> <20111114120546.GA31037@infradead.org> <20111114122932.GA8006@localhost> <20111114124145.GA2698@infradead.org> <20111114130153.GA12916@localhost> <20111114152832.GK5230@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Wu Fengguang , Christoph Hellwig , "linux-fsdevel@vger.kernel.org" , Al Viro , "k-mio@sx.jp.nec.com" , Andrew Morton To: Jan Kara Return-path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:58670 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753107Ab1KNPca (ORCPT ); Mon, 14 Nov 2011 10:32:30 -0500 Content-Disposition: inline In-Reply-To: <20111114152832.GK5230@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Nov 14, 2011 at 04:28:32PM +0100, Jan Kara wrote: > On Mon 14-11-11 21:01:53, Wu Fengguang wrote: > > On Mon, Nov 14, 2011 at 08:41:45PM +0800, Christoph Hellwig wrote: > > > On Mon, Nov 14, 2011 at 08:29:32PM +0800, Wu Fengguang wrote: > > > > > Can you make balance_dirty_pages(_ratelimited) return an error instead > > > > > of opencoding the fatal signal che > > > > > > > > Hmm that means a bigger change to the prototype of the _exported_ > > > > balance_dirty_pages_ratelimited_nr() which impacts out of tree FS... > > > > > > So what? out of tree fses have always been entirely supported on their > > > own, and not a matter for keeping progress back. > > > > OK. Jan, would you do the mm/*.c part in v2? I'll do the various FS > > parts. > Sure, I'll update my patch to balance_dirty_pages(). Should I also update > my patch to generic_perform_write() or does that fall under "various FS > parts" cathegory? I'd be much happier if all bits go in together. IMHO this is a change worthwhile for 3.2 still, so we should probably try to get it in ASAP.