From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 2/2] fs: Make write(2) interruptible by a signal Date: Mon, 14 Nov 2011 15:13:05 -0500 Message-ID: <20111114201305.GB29277@infradead.org> References: <1321287324-15121-1-git-send-email-jack@suse.cz> <1321287324-15121-3-git-send-email-jack@suse.cz> <20111114162600.GB6989@infradead.org> <20111114164647.GP5230@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , Wu Fengguang , Andrew Morton , Al Viro , linux-fsdevel@vger.kernel.org To: Jan Kara Return-path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:60167 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754491Ab1KNUNM (ORCPT ); Mon, 14 Nov 2011 15:13:12 -0500 Content-Disposition: inline In-Reply-To: <20111114164647.GP5230@quack.suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Mon, Nov 14, 2011 at 05:46:47PM +0100, Jan Kara wrote: > There can be loops where the only blocking point is in > balance_dirty_pages() and then using the return value makes sense but > I think such loops would be in minority so maybe the return value doesn't > make much sense after all. Yes, maybe the return value isn't that smart. Sorry for all the noise.