From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Myers Subject: Re: [PATCH 2/3] xfstests 265: add a prealloc and reserve test Date: Tue, 15 Nov 2011 12:21:13 -0600 Message-ID: <20111115182113.GD29840@sgi.com> References: <4EB20505.7070005@cn.fujitsu.com> <4EB205CC.6010509@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, Linux Btrfs , xfs@oss.sgi.com To: WuBo Return-path: Received: from relay3.sgi.com ([192.48.152.1]:52146 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1756860Ab1KOSU6 (ORCPT ); Tue, 15 Nov 2011 13:20:58 -0500 Content-Disposition: inline In-Reply-To: <4EB205CC.6010509@cn.fujitsu.com> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Hi Wu Bo, On Thu, Nov 03, 2011 at 11:09:00AM +0800, WuBo wrote: > This test is for preallocation test. If the disk is full, just with a prealloc > file has some free space that prealloc early. We need to check whether the write > to the free space is success or not. > > Signed-off-by: Wu Bo This test is failing for me because I don't have fallocate installed. I suggest the test could to be changed to check for binaries it uses, possibly the version of those binaries, and then not run unless the right ones are installed. But the best I can do right now is make a note of it. Just a heads up. ;) Regards, Ben