From: Christoph Hellwig <hch@infradead.org>
To: Ben Myers <bpm@sgi.com>
Cc: WuBo <wu.bo@cn.fujitsu.com>,
linux-fsdevel@vger.kernel.org,
Linux Btrfs <linux-btrfs@vger.kernel.org>,
xfs@oss.sgi.com
Subject: Re: [PATCH 2/3] xfstests 265: add a prealloc and reserve test
Date: Tue, 15 Nov 2011 14:08:21 -0500 [thread overview]
Message-ID: <20111115190821.GA15331@infradead.org> (raw)
In-Reply-To: <20111115182113.GD29840@sgi.com>
On Tue, Nov 15, 2011 at 12:21:13PM -0600, Ben Myers wrote:
> Hi Wu Bo,
>
> On Thu, Nov 03, 2011 at 11:09:00AM +0800, WuBo wrote:
> > This test is for preallocation test. If the disk is full, just with a prealloc
> > file has some free space that prealloc early. We need to check whether the write
> > to the free space is success or not.
> >
> > Signed-off-by: Wu Bo <Wu.Bo@cn.fujitsu.com>
>
> This test is failing for me because I don't have fallocate installed. I
> suggest the test could to be changed to check for binaries it uses,
> possibly the version of those binaries, and then not run unless the
> right ones are installed. But the best I can do right now is make a
> note of it.
It might be even better to just use the xfs_io falloc command as we
generally expect an uptodate xfs_io for use with xfstests.
next prev parent reply other threads:[~2011-11-15 19:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-03 3:05 [PATCH 0/3] xfstests: Add a group of reservation space test WuBo
2011-11-03 3:08 ` [PATCH 1/3] xfstests 264: add a copy and reserve test WuBo
2011-11-03 6:55 ` Christoph Hellwig
2011-11-03 8:04 ` WuBo
2011-11-03 3:09 ` [PATCH 2/3] xfstests 265: add a prealloc " WuBo
2011-11-15 18:21 ` Ben Myers
2011-11-15 19:08 ` Christoph Hellwig [this message]
2011-11-16 1:30 ` WuBo
2011-11-03 3:09 ` [PATCH 3/3] xfstests 266: add a write " WuBo
2011-11-17 5:16 ` [PATCH] change fallocate to xfs_io falloc WuBo
2011-11-17 20:50 ` Ben Myers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111115190821.GA15331@infradead.org \
--to=hch@infradead.org \
--cc=bpm@sgi.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=wu.bo@cn.fujitsu.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).