From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH 0/2 v3] Make task in balance_dirty_pages() killable Date: Wed, 16 Nov 2011 19:23:50 +0800 Message-ID: <20111116112350.GA6898@localhost> References: <1321441935-6802-1-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Christoph Hellwig , Al Viro , "linux-fsdevel@vger.kernel.org" To: Jan Kara Return-path: Received: from mga14.intel.com ([143.182.124.37]:31594 "EHLO mga14.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756008Ab1KPLXy (ORCPT ); Wed, 16 Nov 2011 06:23:54 -0500 Content-Disposition: inline In-Reply-To: <1321441935-6802-1-git-send-email-jack@suse.cz> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Nov 16, 2011 at 07:12:13PM +0800, Jan Kara wrote: > > Hello, > > since the discussion has calmed down, here is a third iteration of the patches. > Fengguang, can you put them into your tree and merge them with Linus? Thanks. Sure, thanks for pushing this forward. I'll push them to linux-next and then to Linus. Thanks, Fengguang > Changes since v2: > * removed return value of balance_dirty_pages() since it didn't seem that > useful after all. > * kept fatal_signal_pending() check in generic_perform_write() since I don't think > possible partial writes when app receives SIGKILL are a problem. > > Changes since v1: > * slightly moved the check in balance_dirty_pages() as Fengguang requested > * made balance_dirty_pages() return EINTR if fatal signal was detected > * changed check for signal to check for fatal signal in generic_perform_write() > to avoid unexpected results for userspace applications. > > Honza