From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joel Becker Subject: Re: [PATCH] vfs: Correctly set the dir i_mutex lockdep class Date: Thu, 17 Nov 2011 00:35:11 -0800 Message-ID: <20111117083510.GA7319@noexit.corp.google.com> References: <1320907500-3767-1-git-send-email-tyhicks@canonical.com> <20111110143319.GB26644@quack.suse.cz> <20111110152848.GA5421@boyd> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: John Johansen , Jan Kara , Josh Boyer , Peter Zijlstra , Mark Fasheh , Ingo Molnar , Alexander Viro , linux-fsdevel@vger.kernel.org, ocfs2-devel@oss.oracle.com To: Tyler Hicks Return-path: Content-Disposition: inline In-Reply-To: <20111110152848.GA5421@boyd> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: ocfs2-devel-bounces@oss.oracle.com Errors-To: ocfs2-devel-bounces@oss.oracle.com List-Id: linux-fsdevel.vger.kernel.org On Thu, Nov 10, 2011 at 09:28:49AM -0600, Tyler Hicks wrote: > On 2011-11-10 15:33:19, Jan Kara wrote: > > On Thu 10-11-11 00:45:00, Tyler Hicks wrote: > > > This patch removes the negation from the conditional so that the i_mutex > > > lockdep class is properly set for directory inodes. Special classes are > > > preserved and directory inodes with unmodified classes are set with > > > i_mutex_dir_key. > > Duh, you are right. I wonder how come this did not trigger any lockdep > > messages during my testing with ocfs2 for which I wrote the patch... > > Good question. Adding the ocfs2 maintainers and devel list to cc, as > this patch is likely to change up their lockdep warnings. We don't set special classes for dir->i_mutex. We set special classes on our DLM stuff, and we do it for our system files, but not for regular directories. Joel -- Life's Little Instruction Book #356 "Be there when people need you." http://www.jlbec.org/ jlbec@evilplan.org