From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 3/8] readahead: replace ra->mmap_miss with ra->ra_flags Date: Wed, 23 Nov 2011 12:31:50 -0800 Message-ID: <20111123123150.8a1ac462.akpm@linux-foundation.org> References: <20111121091819.394895091@intel.com> <20111121093846.378529145@intel.com> <20111121150116.094cf194.akpm@linux-foundation.org> <20111123124745.GB7174@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Cc: Linux Memory Management List , linux-fsdevel@vger.kernel.org, Andi Kleen , Steven Whitehouse , Rik van Riel , LKML To: Wu Fengguang Return-path: In-Reply-To: <20111123124745.GB7174@localhost> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Wed, 23 Nov 2011 20:47:45 +0800 Wu Fengguang wrote: > > should be ulong, which is compatible with the bitops.h code. > > Or perhaps we should use a bitfield and let the compiler do the work. > > What if we do > > u16 mmap_miss; > u16 ra_flags; > > That would get rid of this patch. I'd still like to pack the various > flags as well as pattern into one single ra_flags, which makes it > convenient to pass things around (as one single parameter). I'm not sure that this will improve things much... Again, how does the code look if you use a bitfield and let the compiler do the worK? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org