linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Wu Fengguang <fengguang.wu@intel.com>
To: Theodore Tso <tytso@MIT.EDU>
Cc: Jan Kara <jack@suse.cz>,
	Andrew Morton <akpm@linux-foundation.org>,
	Christoph Hellwig <hch@infradead.org>,
	Al Viro <viro@ZenIV.linux.org.uk>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	Kazuya Mio <k-mio@sx.jp.nec.com>,
	Dmitry Monakhov <dmonakhov@openvz.org>,
	Matthew Wilcox <willy@linux.intel.com>
Subject: Re: [PATCH 2/2] fs: Make write(2) interruptible by a signal
Date: Mon, 28 Nov 2011 11:08:42 +0800	[thread overview]
Message-ID: <20111128030842.GA2804@localhost> (raw)
In-Reply-To: <7B2683F5-A926-44CA-9BA8-F71720E50A77@mit.edu>

On Wed, Nov 23, 2011 at 11:06:56PM +0800, Theodore Ts'o wrote:
> 
> On Nov 23, 2011, at 8:27 AM, Wu Fengguang wrote:
> 
> > 
> > Reading Ted's information feed, I tend to disregard the partial write
> > issue: since the "broken" applications will already fail and get
> > punished in various other cases, I don't care adding one more penalty
> > case to them :-P
> 
> Just wait until you have a bunch of rabid application programmers,
> questioning your judgement, your morality, and even your paternity.
> :-)

Ah OK, that sounds frightening. Hmm, till now every one have
acknowledged the possibility of data corruption, only that
people have different perceptions of the severeness.

Let's rethink things this way: "Is it a _worthwhile_ risk at all?"
I'm afraid not. Considering the origin of this patch

[BUG] aborted ext4 leads to inifinity loop in balance_dirty_pages
http://www.spinics.net/lists/linux-ext4/msg28464.html

I *think* Jan's first patch is already enough for fixing the bug. IWO
the patch we worried/discussed so much is really an optional one. I
would imagine the easy and safe solution is to just drop it. Any
objections?

Thanks,
Fengguang

  reply	other threads:[~2011-11-28  3:08 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-16 11:12 [PATCH 0/2 v3] Make task in balance_dirty_pages() killable Jan Kara
2011-11-16 11:12 ` [PATCH 1/2] mm: " Jan Kara
2011-11-16 11:28   ` Wu Fengguang
2011-11-16 12:58     ` Jan Kara
2011-11-16 11:12 ` [PATCH 2/2] fs: Make write(2) interruptible by a signal Jan Kara
2011-11-16 11:44   ` Wu Fengguang
2011-11-16 12:54     ` Jan Kara
2011-11-16 13:11       ` Wu Fengguang
2011-11-22 22:28     ` Andrew Morton
2011-11-23  9:05       ` Wu Fengguang
2011-11-23  9:50         ` Andrew Morton
2011-11-23 12:27           ` [PATCH 2/2] " Theodore Tso
2011-11-23 20:29             ` Andrew Morton
2011-11-24 19:27               ` Matthew Wilcox
2011-11-24 20:53                 ` Ted Ts'o
2011-11-25  0:10                   ` Matthew Wilcox
2011-11-24 20:53                 ` Jan Kara
2011-11-23 13:08         ` [PATCH 2/2] fs: " Jan Kara
2011-11-23 13:27           ` Wu Fengguang
2011-11-23 15:06             ` Theodore Tso
2011-11-28  3:08               ` Wu Fengguang [this message]
2011-11-28  3:33                 ` [PATCH] writeback: add a safety limit to the SIGKILL abort Wu Fengguang
2011-11-29 14:18                   ` Jan Kara
2011-11-29 14:16                 ` [PATCH 2/2] fs: Make write(2) interruptible by a signal Jan Kara
2011-11-16 11:23 ` [PATCH 0/2 v3] Make task in balance_dirty_pages() killable Wu Fengguang
  -- strict thread matches above, loose matches on Subject: below --
2011-11-14 16:15 [PATCH 0/2 v2] " Jan Kara
2011-11-14 16:15 ` [PATCH 2/2] fs: Make write(2) interruptible by a signal Jan Kara
2011-11-14 16:26   ` Christoph Hellwig
2011-11-14 16:46     ` Jan Kara
2011-11-14 20:13       ` Christoph Hellwig
2011-11-14 22:19   ` Andrew Morton
2011-11-15 11:23     ` Jan Kara
2011-11-14 11:10 [PATCH 0/2] Make task doing heavy writing killable Jan Kara
2011-11-14 11:10 ` [PATCH 2/2] fs: Make write(2) interruptible by a signal Jan Kara
2011-11-14 12:12   ` Matthew Wilcox
2011-11-14 12:15   ` Wu Fengguang
2011-11-14 12:34     ` Jan Kara
2011-11-14 14:16       ` Matthew Wilcox
2011-11-14 15:30         ` Jan Kara
2011-11-14 18:44           ` Jeremy Allison

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111128030842.GA2804@localhost \
    --to=fengguang.wu@intel.com \
    --cc=akpm@linux-foundation.org \
    --cc=dmonakhov@openvz.org \
    --cc=hch@infradead.org \
    --cc=jack@suse.cz \
    --cc=k-mio@sx.jp.nec.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=tytso@MIT.EDU \
    --cc=viro@ZenIV.linux.org.uk \
    --cc=willy@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).