linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: Max Kellermann <mk@cm4all.com>
Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fs/namei: waiting for mutex during name lookups is "killable"
Date: Mon, 28 Nov 2011 05:19:37 -0700	[thread overview]
Message-ID: <20111128121936.GR4387@parisc-linux.org> (raw)
In-Reply-To: <20111128113918.23050.25938.stgit@rabbit.intern.cm-ag>

On Mon, Nov 28, 2011 at 12:39:18PM +0100, Max Kellermann wrote:
> Use mutex_lock_killable() instead of mutex_lock() during name lookups,
> to allow killing the process while it's waiting.

This is cool.  Could you describe what situations this mutex gets held
for a user-noticable length of time, and how you tested this patch?

-- 
Matthew Wilcox				Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."

  reply	other threads:[~2011-11-28 12:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-11-28 11:39 [PATCH] fs/namei: waiting for mutex during name lookups is "killable" Max Kellermann
2011-11-28 12:19 ` Matthew Wilcox [this message]
2011-11-28 12:30   ` Max Kellermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20111128121936.GR4387@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mk@cm4all.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).