From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [PATCH] fs/namei: waiting for mutex during name lookups is "killable" Date: Mon, 28 Nov 2011 05:19:37 -0700 Message-ID: <20111128121936.GR4387@parisc-linux.org> References: <20111128113918.23050.25938.stgit@rabbit.intern.cm-ag> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org To: Max Kellermann Return-path: Content-Disposition: inline In-Reply-To: <20111128113918.23050.25938.stgit@rabbit.intern.cm-ag> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Mon, Nov 28, 2011 at 12:39:18PM +0100, Max Kellermann wrote: > Use mutex_lock_killable() instead of mutex_lock() during name lookups, > to allow killing the process while it's waiting. This is cool. Could you describe what situations this mutex gets held for a user-noticable length of time, and how you tested this patch? -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."