From: Josef Bacik <josef@redhat.com>
To: Jan Kara <jack@suse.cz>
Cc: Josef Bacik <josef@redhat.com>,
linux-fsdevel@vger.kernel.org, linux-btrfs@vger.kernel.org,
viro@ZenIV.linux.org.uk, hch@infradead.org
Subject: Re: [PATCH] fs: push file_update_time into ->page_mkwrite
Date: Tue, 29 Nov 2011 11:08:39 -0500 [thread overview]
Message-ID: <20111129160838.GA14560@localhost.localdomain> (raw)
In-Reply-To: <20111129155020.GQ5635@quack.suse.cz>
On Tue, Nov 29, 2011 at 04:50:20PM +0100, Jan Kara wrote:
> On Tue 29-11-11 10:40:59, Josef Bacik wrote:
> > The fault code has been calling file_update_time after ->page_mkwrite after it
> > drops the page lock, but this is annoying because this calls mark_inode_dirty
> > which can fail in Btrfs, so we want to be able to do these updates in
> > ->page_mkwrite so we can get an error back to the user. So get rid of the
> > file_update_time calls in the fault code and push it into everybody who has a
> > ->page_mkwrite. I didn't do this for ubifs because it appears that ubifs
> > already updates the time itself in ->page_mkwrite, presumebly for the same
> > reasons as btrfs, so I left it as is. Thanks,
> But this effectively disables atime updates on mmaped writes for ext2,
> ext3, and similar filesystems which is a no-go IMHO.
>
Heh doh you're right, I have vacation brain. Thanks,
Josef
next prev parent reply other threads:[~2011-11-29 16:09 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-29 15:40 [PATCH] fs: push file_update_time into ->page_mkwrite Josef Bacik
2011-11-29 15:50 ` Jan Kara
2011-11-29 16:08 ` Josef Bacik [this message]
2011-12-21 4:11 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111129160838.GA14560@localhost.localdomain \
--to=josef@redhat.com \
--cc=hch@infradead.org \
--cc=jack@suse.cz \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).