From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH 6/9] readahead: add /debug/readahead/stats Date: Wed, 30 Nov 2011 08:44:24 +0800 Message-ID: <20111130004424.GC11147@localhost> References: <20111129130900.628549879@intel.com> <20111129131456.666312513@intel.com> <20111129152106.GN5635@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andrew Morton , Andi Kleen , Ingo Molnar , Jens Axboe , Peter Zijlstra , Rik van Riel , Linux Memory Management List , "linux-fsdevel@vger.kernel.org" , LKML To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20111129152106.GN5635@quack.suse.cz> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org > This looks all inherently racy (which doesn't matter much as you suggest) > so I just wanted to suggest that if you used per-cpu counters you'd get > race-free and faster code at the cost of larger data structures and using > percpu_counter_add() instead of ++ (which doesn't seem like a big > complication to me). No problem. I'll switch to per-cpu counters in next post. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org