From: Alasdair G Kergon <agk@redhat.com>
To: Jan Kara <jack@suse.cz>, Mikulas Patocka <mpatocka@redhat.com>
Cc: esandeen@redhat.com, linux-kernel@vger.kernel.org,
dm-devel@redhat.com, linux-fsdevel@vger.kernel.org,
Christopher Chaltain <christopher.chaltain@canonical.com>,
Valerie Aurora <val@vaaconsulting.com>
Subject: Re: [dm-devel] [PATCH] deadlock with suspend and quotas
Date: Wed, 30 Nov 2011 14:09:13 +0000 [thread overview]
Message-ID: <20111130140913.GX7595@agk-dp.fab.redhat.com> (raw)
In-Reply-To: <20111129101901.GA5635@quack.suse.cz>
On Tue, Nov 29, 2011 at 11:19:01AM +0100, Jan Kara wrote:
> So I believe the consensus was that we should not block sync or flusher
Consensus where?
> thread on frozen filesystem. Firstly, it's kind of ugly from user
> perspective (you cannot sync filesystems on your system while one
> filesystem is frozen???), secondly, in case of flusher thread it has some
> serious implications if there are more filesystems on the same device - you
> would effectively stop any writeback to the device possibly hanging the
> whole system due to dirty limit being exceeded. So at least in these two
> cases we should just ignore frozen filesystem.
The sync only needs to block on a particular fs if there is data to flush.
A sync that originated in a way that can only be independent of any
application that is changing the fs may skip that fs if it is frozen.
It's the user's responsibility only to freeze filesystems for very brief
periods of time if they are still being changed.
?
Alasdair
next prev parent reply other threads:[~2011-11-30 14:09 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-25 20:25 [PATCH] deadlock with suspend and quotas Mikulas Patocka
2011-11-28 15:04 ` Jan Kara
2011-11-28 21:00 ` Valerie Aurora
2011-11-28 21:14 ` Mikulas Patocka
2011-11-28 23:32 ` Mikulas Patocka
2011-11-29 10:19 ` Jan Kara
2011-11-29 10:21 ` Jan Kara
2011-11-29 11:06 ` Mikulas Patocka
2011-11-29 11:11 ` Jan Kara
2011-11-29 12:54 ` Mikulas Patocka
2011-11-29 13:09 ` Jan Kara
2011-11-29 13:18 ` [dm-devel] " Alasdair G Kergon
2011-11-29 13:32 ` Jan Kara
2011-11-29 16:33 ` Eric Sandeen
2011-11-30 6:52 ` Mikulas Patocka
2011-11-30 11:16 ` Jan Kara
2011-11-30 12:14 ` Mikulas Patocka
2011-11-30 13:05 ` Alasdair G Kergon
2011-11-30 16:53 ` Jan Kara
2011-11-30 17:09 ` Mikulas Patocka
2011-11-30 13:33 ` Alasdair G Kergon
2011-11-30 13:48 ` Alasdair G Kergon
2011-11-30 16:36 ` Mikulas Patocka
2011-11-30 16:34 ` Mikulas Patocka
2011-12-01 0:34 ` Jan Kara
2011-11-30 14:09 ` Alasdair G Kergon [this message]
2011-11-30 16:53 ` Mikulas Patocka
2011-12-01 0:03 ` Jan Kara
2011-11-30 17:03 ` Mikulas Patocka
2011-11-29 20:00 ` Kamal Mostafa
2012-01-03 3:30 ` Al Viro
2012-01-03 18:22 ` Mikulas Patocka
2012-01-03 18:35 ` Mikulas Patocka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111130140913.GX7595@agk-dp.fab.redhat.com \
--to=agk@redhat.com \
--cc=christopher.chaltain@canonical.com \
--cc=dm-devel@redhat.com \
--cc=esandeen@redhat.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=val@vaaconsulting.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).