From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andi Kleen Subject: Re: [PATCH 1/3] DEBUGFS: Automatically create parents for debugfs files Date: Fri, 2 Dec 2011 20:42:19 +0100 Message-ID: <20111202194219.GU24062@one.firstfloor.org> References: <1322851407-17182-1-git-send-email-andi@firstfloor.org> <1322851407-17182-2-git-send-email-andi@firstfloor.org> <20111202191724.GA13613@kroah.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Andi Kleen , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, fengguang.wu@intel.com, Andi Kleen To: Greg KH Return-path: Content-Disposition: inline In-Reply-To: <20111202191724.GA13613@kroah.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Dec 02, 2011 at 11:17:24AM -0800, Greg KH wrote: > I like this, but some documentation will probably need to be added > somwhere saying that it's now legal to create a debugfs file with > "this/is/a/tree" and have it all be expanded out. Ok. Updating the kerneldoc entries. > > And yes, cleaning up the directories shouldn't be a big issue, but what > if the directory is already there and it tries to be created again? > Shouldn't you do a lookup first and use that dentry if it's there? In this case debugfs_create_dir() errors out, the caller ignores the error and just looks it up. So yes should work. -Andi -- ak@linux.intel.com -- Speaking for myself only.