Re: [PATCH] FUSE: Notifying the kernel of deletion.

["J. Bruce Fields" <bfields@fieldses.org>]

On Tue, Dec 06, 2011 at 09:08:48PM +0100, John Muir wrote:
> On 2011.12.06, at 21:03 , J. Bruce Fields wrote:
> 
> > On Tue, Dec 06, 2011 at 07:50:33PM +0100, John Muir wrote:
> >> Allows a FUSE file-system to tell the kernel when a file or directory is deleted. If the specified dentry has the specified inode number, the kernel will unhash it.
> >> 
> >> Signed-off-by: John Muir <john@jmuir.com>
> >> ---
> >> Please find below a patch that add notification of deletion to the FUSE kernel interface. These patches allow the file-system to tell the kernel when a file (and more particularly) a directory is deleted. This is needed because using the current 'notify_inval_entry' does not cause the kernel to clean up directories that are in use properly, and as a result the users of those directories see incorrect semantics from the file-system. The error condition seen when 'notify_inval_entry' is used to notify of a deleted directory is avoided when 'notify_delete' is used instead.
> > 
> > You've put all this extra text after the ---, meaning it would be
> > discarded before going into git.  But this sort of "why we're doing
> > this" information is exactly what you want in a changelog.
> > 
> > --b.
> 
> I was aware of this. My intention was that the first two lines would be in the change log, given that my explanation was rather long. If it isn't too long, and the full explanation can go into the change log, I can definitely re-submit.

For me, sure, changelog bytes are cheap, and a summary of the patch is
nice but never as useful as "here's why we're doing it".

--b.