From: Matthew Wilcox <matthew@wil.cx>
To: Al Viro <viro@ZenIV.linux.org.uk>
Cc: linux-fsdevel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC][patch series] vfsmount gutting
Date: Thu, 8 Dec 2011 05:19:57 -0700 [thread overview]
Message-ID: <20111208121956.GX4387@parisc-linux.org> (raw)
In-Reply-To: <20111208010251.GF2203@ZenIV.linux.org.uk>
On Thu, Dec 08, 2011 at 01:02:52AM +0000, Al Viro wrote:
> OK, that's something I wanted to do for a long time - struct vfsmount
> contains too much stuff that is strictily VFS-internal and not needed by
> anything outside of a very small subset of VFS, at that. As the matter of
> fact, only 3 fields, 1 of them redundant, are used by code outside of that
> area - it's mnt_flags ("how it's mounted"), mnt_root ("what dentry tree
> is mounted here", assign-once thing) and mnt_sb (always equal to
> mnt_root->d_sb, also assign-once, might or might not be not needed).
If only these 3 fields are used, why not make the definition of struct
vfsmount entirely hidden, and add accessor functions for those three?
--
Matthew Wilcox Intel Open Source Technology Centre
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours. We can't possibly take such
a retrograde step."
next prev parent reply other threads:[~2011-12-08 12:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-08 1:02 [RFC][patch series] vfsmount gutting Al Viro
2011-12-08 1:16 ` Linus Torvalds
2011-12-08 12:19 ` Matthew Wilcox [this message]
2011-12-08 13:10 ` Al Viro
2011-12-09 1:05 ` James Morris
2011-12-09 4:53 ` Tetsuo Handa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111208121956.GX4387@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).