From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Wilcox Subject: Re: [RFC][patch series] vfsmount gutting Date: Thu, 8 Dec 2011 05:19:57 -0700 Message-ID: <20111208121956.GX4387@parisc-linux.org> References: <20111208010251.GF2203@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, Linus Torvalds , linux-kernel@vger.kernel.org To: Al Viro Return-path: Content-Disposition: inline In-Reply-To: <20111208010251.GF2203@ZenIV.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Dec 08, 2011 at 01:02:52AM +0000, Al Viro wrote: > OK, that's something I wanted to do for a long time - struct vfsmount > contains too much stuff that is strictily VFS-internal and not needed by > anything outside of a very small subset of VFS, at that. As the matter of > fact, only 3 fields, 1 of them redundant, are used by code outside of that > area - it's mnt_flags ("how it's mounted"), mnt_root ("what dentry tree > is mounted here", assign-once thing) and mnt_sb (always equal to > mnt_root->d_sb, also assign-once, might or might not be not needed). If only these 3 fields are used, why not make the definition of struct vfsmount entirely hidden, and add accessor functions for those three? -- Matthew Wilcox Intel Open Source Technology Centre "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."