From: Wu Fengguang <fengguang.wu@intel.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: writeback fixes for 3.2-rc5
Date: Tue, 13 Dec 2011 09:44:56 +0800 [thread overview]
Message-ID: <20111213014456.GA9963@localhost> (raw)
In-Reply-To: <20111212204634.GB5214@quack.suse.cz>
On Tue, Dec 13, 2011 at 04:46:34AM +0800, Jan Kara wrote:
> Hi Fengguang,
>
> On Mon 12-12-11 18:29:48, Wu Fengguang wrote:
> > May I ask if you see any problems pushing these patches to Linus?
> Sorry, this somehow escaped my attention. Patches 1, 2, 3, and 5 are
> fine. I'm not sure about patch 4 - I'm not against it but e.g. on
> single-cpu machine, bdi_stat_error() is 1 so there the patch won't help
As the comment said, actually 1 is enough to let the tasks go through.
It may sound terrible to write 1 page at a time, however it's already
much better than being blocked there forever. The user experience is
totally different according to my tests, because most tasks are not IO
intensive at all, they are blocked simply on writing some small file.
> much. Enconding fixed constant like you had in the first version of the
> patch doesn't look nice either. But I don't have a better solution...
My typical need on the global exceeded case is "please at least let me
ssh in and kill some task or raise the dirty limit to break out of the
error condition". IMHO the patch is good enough for that need.
Thanks,
Fengguang
> >
> > On Mon, Dec 05, 2011 at 02:22:13PM +0800, Wu Fengguang wrote:
> > > Hi,
> > >
> > > I'd like to push these patches to Linus later this week. Please review.
> > >
> > > - abort write(2) on SIGKILL
> > > - 2 patches to keep system responsive on stalled NFS mount
> > > - 2 comment patches
> > >
> > > [PATCH 1/5] writeback: Fix issue on make htmldocs
> > > [PATCH 2/5] fs: Make write(2) interruptible by a fatal signal
> > > [PATCH 3/5] writeback: comment on the bdi dirty threshold
> > > [PATCH 4/5] writeback: permit through good bdi even when global
> > > [PATCH 5/5] writeback: set max_pause to lowest value on zero
> > >
> > > Thanks,
> > > Fengguang
> > > --
> > > To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> > > the body of a message to majordomo@vger.kernel.org
> > > More majordomo info at http://vger.kernel.org/majordomo-info.html
> --
> Jan Kara <jack@suse.cz>
> SUSE Labs, CR
next prev parent reply other threads:[~2011-12-13 1:55 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-05 6:22 writeback fixes for 3.2-rc5 Wu Fengguang
2011-12-05 6:22 ` [PATCH 1/5] writeback: Fix issue on make htmldocs Wu Fengguang
2011-12-05 6:22 ` [PATCH 2/5] fs: Make write(2) interruptible by a fatal signal Wu Fengguang
2011-12-05 6:22 ` [PATCH 3/5] writeback: comment on the bdi dirty threshold Wu Fengguang
2011-12-05 6:22 ` [PATCH 4/5] writeback: permit through good bdi even when global dirty exceeded Wu Fengguang
2011-12-05 6:22 ` [PATCH 5/5] writeback: set max_pause to lowest value on zero bdi_dirty Wu Fengguang
[not found] ` <20111212102947.GA6731@localhost>
[not found] ` <20111212204634.GB5214@quack.suse.cz>
2011-12-13 1:44 ` Wu Fengguang [this message]
2011-12-13 10:57 ` writeback fixes for 3.2-rc5 Jan Kara
2011-12-13 11:24 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111213014456.GA9963@localhost \
--to=fengguang.wu@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).