From: Al Viro <viro@ZenIV.linux.org.uk>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Eric Paris <eparis@redhat.com>,
akpm@linux-foundation.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] audit: fix mark refcounting
Date: Thu, 15 Dec 2011 09:01:51 +0000 [thread overview]
Message-ID: <20111215090151.GR2203@ZenIV.linux.org.uk> (raw)
In-Reply-To: <87fwgmjjr9.fsf@tucsk.pomaz.szeredi.hu>
On Thu, Dec 15, 2011 at 09:56:26AM +0100, Miklos Szeredi wrote:
> > Guys, does anybody have a real demonstration of the breakage cured by
> > pinning the mark down in audit_watch.c ->handle_event()? Or is that
> > a pure theory?
>
> Yes it does fix the BUG. Test case in patch.
>
> > Is ->handle_event() argument held by caller?
>
> Well, obviously not, otherwise we wouldn't hit the bug.
>
> > Eric? If that's the case,
> > we don't need to do anything with audit_watch.c instance; otherwise,
> > both that one and inotify_handle_event() are in trouble...
>
> Yep.
I wonder if the right fix is to do it here and not in caller, though...
OTOH, usually we don't hit destroy at all, so it's probably better to
handle it in the individual instances...
OK, consider the audit_watch.c part ACKed; inotify counterpart needs a similar
patch, AFAICS.
next prev parent reply other threads:[~2011-12-15 9:01 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-07 14:59 [PATCH] audit: fix mark refcounting Miklos Szeredi
2011-11-15 14:12 ` Miklos Szeredi
2011-11-15 14:31 ` Eric Paris
2011-12-14 14:35 ` [PATCH resend] " Miklos Szeredi
2011-12-15 2:15 ` Linus Torvalds
2011-12-15 8:40 ` Al Viro
2011-12-15 8:56 ` Miklos Szeredi
2011-12-15 9:01 ` Al Viro [this message]
2011-12-15 9:03 ` Miklos Szeredi
2011-12-15 20:06 ` Lino Sanfilippo
2011-12-15 22:28 ` Eric Paris
2011-12-15 22:34 ` Linus Torvalds
2011-12-15 22:55 ` Al Viro
2012-01-12 16:59 ` Miklos Szeredi
2011-12-15 16:48 ` Linus Torvalds
2011-12-15 8:49 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111215090151.GR2203@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=eparis@redhat.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).