From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH v2 0/2] vfs: truncate bug fixes Date: Thu, 22 Dec 2011 09:10:22 +0000 Message-ID: <20111222091022.GO23916@ZenIV.linux.org.uk> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, linux-security-module@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, zohar@linux.vnet.ibm.com To: Dmitry Kasatkin Return-path: Content-Disposition: inline In-Reply-To: Sender: linux-security-module-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Thu, Dec 22, 2011 at 10:55:24AM +0200, Dmitry Kasatkin wrote: > When a file is opened with O_TRUNC or truncated with truncate()/ftruncate(), > and then closed, iversion is not updated. This patch uses ATTR_OPEN flag, > which is currently used to identify files opened with O_TRUNC, > as an indication to increment iversion. > Also it adds passing of this flag from do_sys_truncate and do_sys_ftruncate. > To reflect real meaning, ATTR_OPEN is suggested to be renamed to ATTR_TRUNC. Um... Is there any difference left between that and ATTR_SIZE, then?