* [PATCH] udf: Mark LVID buffer as uptodate before marking it dirty
@ 2011-12-23 11:10 Jan Kara
2011-12-23 11:39 ` Namjae Jeon
0 siblings, 1 reply; 3+ messages in thread
From: Jan Kara @ 2011-12-23 11:10 UTC (permalink / raw)
To: linux-fsdevel; +Cc: LKML, Jan Kara
When we hit EIO while writing LVID, the buffer uptodate bit is cleared.
This then results in an anoying warning from mark_buffer_dirty() when we
write the buffer again. So just set uptodate flag unconditionally.
Signed-off-by: Jan Kara <jack@suse.cz>
---
fs/udf/super.c | 6 ++++++
1 files changed, 6 insertions(+), 0 deletions(-)
I carry this patch in my tree and will merge it with Linus in the next
merge window if noone objects.
diff --git a/fs/udf/super.c b/fs/udf/super.c
index e185253..87cb24a 100644
--- a/fs/udf/super.c
+++ b/fs/udf/super.c
@@ -1799,6 +1799,12 @@ static void udf_close_lvid(struct super_block *sb)
le16_to_cpu(lvid->descTag.descCRCLength)));
lvid->descTag.tagChecksum = udf_tag_checksum(&lvid->descTag);
+ /*
+ * We set buffer uptodate unconditionally here to avoid spurious
+ * warnings from mark_buffer_dirty() when previous EIO has marked
+ * the buffer as !uptodate
+ */
+ set_buffer_uptodate(bh);
mark_buffer_dirty(bh);
sbi->s_lvid_dirty = 0;
mutex_unlock(&sbi->s_alloc_mutex);
--
1.7.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] udf: Mark LVID buffer as uptodate before marking it dirty
2011-12-23 11:10 [PATCH] udf: Mark LVID buffer as uptodate before marking it dirty Jan Kara
@ 2011-12-23 11:39 ` Namjae Jeon
2011-12-23 11:49 ` Jan Kara
0 siblings, 1 reply; 3+ messages in thread
From: Namjae Jeon @ 2011-12-23 11:39 UTC (permalink / raw)
To: Jan Kara; +Cc: linux-fsdevel, LKML
2011/12/23 Jan Kara <jack@suse.cz>:
> When we hit EIO while writing LVID, the buffer uptodate bit is cleared.
> This then results in an anoying warning from mark_buffer_dirty() when we
> write the buffer again. So just set uptodate flag unconditionally.
>
> Signed-off-by: Jan Kara <jack@suse.cz>
Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>
> ---
Hi. Jan.
looks good to me !!.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] udf: Mark LVID buffer as uptodate before marking it dirty
2011-12-23 11:39 ` Namjae Jeon
@ 2011-12-23 11:49 ` Jan Kara
0 siblings, 0 replies; 3+ messages in thread
From: Jan Kara @ 2011-12-23 11:49 UTC (permalink / raw)
To: Namjae Jeon; +Cc: Jan Kara, linux-fsdevel, LKML
On Fri 23-12-11 20:39:17, Namjae Jeon wrote:
> 2011/12/23 Jan Kara <jack@suse.cz>:
> > When we hit EIO while writing LVID, the buffer uptodate bit is cleared.
> > This then results in an anoying warning from mark_buffer_dirty() when we
> > write the buffer again. So just set uptodate flag unconditionally.
> >
> > Signed-off-by: Jan Kara <jack@suse.cz>
> Reviewed-by: Namjae Jeon <linkinjeon@gmail.com>
> > ---
> Hi. Jan.
> looks good to me !!.
Thanks for review!
Honza
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-12-23 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-23 11:10 [PATCH] udf: Mark LVID buffer as uptodate before marking it dirty Jan Kara
2011-12-23 11:39 ` Namjae Jeon
2011-12-23 11:49 ` Jan Kara
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).