* docker overlay support broken post v4.8 [not found] <1844859631.492693.1476279971647.JavaMail.zimbra@redhat.com> @ 2016-10-12 13:54 ` CAI Qian 2016-10-13 20:38 ` [bisected] " CAI Qian 0 siblings, 1 reply; 8+ messages in thread From: CAI Qian @ 2016-10-12 13:54 UTC (permalink / raw) To: linux-fsdevel; +Cc: Miklos Szeredi, Al Viro, Vivek Goyal Some patches went into the 4.9 merge window broke docker overlay support even with selinux disabled (setenforce 0). # docker run -it fedora bash /usr/bin/docker-latest: Error response from daemon: error creating overlay mount to /var/lib/docker-latest/overlay/8ffc75b527de2863daef50a7c88a382b84953a0d40f49c40d2a9f504d9e8123c-init/merged: operation not supported. See '/usr/bin/docker-latest run --help'. This message splits in the console. [61250.857832] SELinux: (dev overlay, type overlay) has no xattr support CAI Qian ^ permalink raw reply [flat|nested] 8+ messages in thread
* [bisected] Re: docker overlay support broken post v4.8 2016-10-12 13:54 ` docker overlay support broken post v4.8 CAI Qian @ 2016-10-13 20:38 ` CAI Qian 2016-10-13 20:40 ` Al Viro 2016-10-13 21:16 ` Vivek Goyal 0 siblings, 2 replies; 8+ messages in thread From: CAI Qian @ 2016-10-13 20:38 UTC (permalink / raw) To: Andreas Gruenbacher, Al Viro; +Cc: Miklos Szeredi, Vivek Goyal, linux-fsdevel ----- Original Message ----- > From: "CAI Qian" <caiqian@redhat.com> > Sent: Wednesday, October 12, 2016 9:54:52 AM > Subject: docker overlay support broken post v4.8 > > Some patches went into the 4.9 merge window broke docker overlay support even > with > selinux disabled (setenforce 0). > > # docker run -it fedora bash > /usr/bin/docker-latest: Error response from daemon: error creating overlay > mount to > /var/lib/docker-latest/overlay/8ffc75b527de2863daef50a7c88a382b84953a0d40f49c40d2a9f504d9e8123c-init/merged: > operation not supported. > See '/usr/bin/docker-latest run --help'. > > This message splits in the console. > [61250.857832] SELinux: (dev overlay, type overlay) has no xattr support Reverted the patchset of "Xattr inode operation removal" against the latest mainline fixed the problem, i.e., commits below in order. fd50ecaddf8372a1d96e0daeaac0f93cf04e4d42 6c6ef9f26e598fb977f60935e109cd5b266c941a bf3ee71363c0b44acb62f375aea470262ac4210a 5d6c31910bc0713e37628dc0ce677dcb13c8ccf4 f5c244383725a6de06bc62fa7c54c0ea0d942eec 5f6e59ae8277cef221fdbf9b12f0c4f80db59944 d0a5b995a308347fdb1bb0412df32acd0312523b CAI Qian ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [bisected] Re: docker overlay support broken post v4.8 2016-10-13 20:38 ` [bisected] " CAI Qian @ 2016-10-13 20:40 ` Al Viro 2016-10-13 20:46 ` CAI Qian 2016-10-13 21:16 ` Vivek Goyal 1 sibling, 1 reply; 8+ messages in thread From: Al Viro @ 2016-10-13 20:40 UTC (permalink / raw) To: CAI Qian; +Cc: Andreas Gruenbacher, Miklos Szeredi, Vivek Goyal, linux-fsdevel On Thu, Oct 13, 2016 at 04:38:23PM -0400, CAI Qian wrote: > > > ----- Original Message ----- > > From: "CAI Qian" <caiqian@redhat.com> > > Sent: Wednesday, October 12, 2016 9:54:52 AM > > Subject: docker overlay support broken post v4.8 > > > > Some patches went into the 4.9 merge window broke docker overlay support even > > with > > selinux disabled (setenforce 0). > > > > # docker run -it fedora bash > > /usr/bin/docker-latest: Error response from daemon: error creating overlay > > mount to > > /var/lib/docker-latest/overlay/8ffc75b527de2863daef50a7c88a382b84953a0d40f49c40d2a9f504d9e8123c-init/merged: > > operation not supported. > > See '/usr/bin/docker-latest run --help'. > > > > This message splits in the console. > > [61250.857832] SELinux: (dev overlay, type overlay) has no xattr support > Reverted the patchset of "Xattr inode operation removal" against the latest mainline > fixed the problem, i.e., commits below in order. > > fd50ecaddf8372a1d96e0daeaac0f93cf04e4d42 > 6c6ef9f26e598fb977f60935e109cd5b266c941a > bf3ee71363c0b44acb62f375aea470262ac4210a > 5d6c31910bc0713e37628dc0ce677dcb13c8ccf4 > f5c244383725a6de06bc62fa7c54c0ea0d942eec > 5f6e59ae8277cef221fdbf9b12f0c4f80db59944 > d0a5b995a308347fdb1bb0412df32acd0312523b Where in that branch has that started? Or is it interaction upon merge between two branches, each working on its own? ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [bisected] Re: docker overlay support broken post v4.8 2016-10-13 20:40 ` Al Viro @ 2016-10-13 20:46 ` CAI Qian 0 siblings, 0 replies; 8+ messages in thread From: CAI Qian @ 2016-10-13 20:46 UTC (permalink / raw) To: Al Viro; +Cc: Andreas Gruenbacher, Miklos Szeredi, Vivek Goyal, linux-fsdevel ----- Original Message ----- > From: "Al Viro" <viro@ZenIV.linux.org.uk> > Sent: Thursday, October 13, 2016 4:40:58 PM > Subject: Re: [bisected] Re: docker overlay support broken post v4.8 > > > Reverted the patchset of "Xattr inode operation removal" against the latest > > mainline > > fixed the problem, i.e., commits below in order. > > > > fd50ecaddf8372a1d96e0daeaac0f93cf04e4d42 > > 6c6ef9f26e598fb977f60935e109cd5b266c941a > > bf3ee71363c0b44acb62f375aea470262ac4210a > > 5d6c31910bc0713e37628dc0ce677dcb13c8ccf4 > > f5c244383725a6de06bc62fa7c54c0ea0d942eec > > 5f6e59ae8277cef221fdbf9b12f0c4f80db59944 > > d0a5b995a308347fdb1bb0412df32acd0312523b > > Where in that branch has that started? Or is it interaction upon merge > between two branches, each working on its own? > Everything is tested on the mainline's master branch. I just use 'git show' the above commits and then 'patch -Np1 -R' to revert them. CAI Qian ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [bisected] Re: docker overlay support broken post v4.8 2016-10-13 20:38 ` [bisected] " CAI Qian 2016-10-13 20:40 ` Al Viro @ 2016-10-13 21:16 ` Vivek Goyal 2016-10-13 21:39 ` Vivek Goyal 1 sibling, 1 reply; 8+ messages in thread From: Vivek Goyal @ 2016-10-13 21:16 UTC (permalink / raw) To: CAI Qian; +Cc: Andreas Gruenbacher, Al Viro, Miklos Szeredi, linux-fsdevel On Thu, Oct 13, 2016 at 04:38:23PM -0400, CAI Qian wrote: > > > ----- Original Message ----- > > From: "CAI Qian" <caiqian@redhat.com> > > Sent: Wednesday, October 12, 2016 9:54:52 AM > > Subject: docker overlay support broken post v4.8 > > > > Some patches went into the 4.9 merge window broke docker overlay support even > > with > > selinux disabled (setenforce 0). > > > > # docker run -it fedora bash > > /usr/bin/docker-latest: Error response from daemon: error creating overlay > > mount to > > /var/lib/docker-latest/overlay/8ffc75b527de2863daef50a7c88a382b84953a0d40f49c40d2a9f504d9e8123c-init/merged: > > operation not supported. > > See '/usr/bin/docker-latest run --help'. > > > > This message splits in the console. > > [61250.857832] SELinux: (dev overlay, type overlay) has no xattr support > Reverted the patchset of "Xattr inode operation removal" against the latest mainline > fixed the problem, i.e., commits below in order. > > fd50ecaddf8372a1d96e0daeaac0f93cf04e4d42 > 6c6ef9f26e598fb977f60935e109cd5b266c941a > bf3ee71363c0b44acb62f375aea470262ac4210a > 5d6c31910bc0713e37628dc0ce677dcb13c8ccf4 > f5c244383725a6de06bc62fa7c54c0ea0d942eec > 5f6e59ae8277cef221fdbf9b12f0c4f80db59944 > d0a5b995a308347fdb1bb0412df32acd0312523b Looking at selinux code, it seems to be coming from following code. Looks like in case of overlay inode, we are not setting IOP_XATTR? Vivek sb_finish_set_opts() if (sbsec->behavior == SECURITY_FS_USE_XATTR) { /* Make sure that the xattr handler exists and that no error other than -ENODATA is returned by getxattr on the root directory. -ENODATA is ok, as this may be the first boot of the SELinux kernel before we have assigned xattr values to the filesystem. */ if (!(root_inode->i_opflags & IOP_XATTR)) { printk(KERN_WARNING "SELinux: (dev %s, type %s) has no " "xattr support\n", sb->s_id, sb->s_type->name); rc = -EOPNOTSUPP; goto out; } ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [bisected] Re: docker overlay support broken post v4.8 2016-10-13 21:16 ` Vivek Goyal @ 2016-10-13 21:39 ` Vivek Goyal 2016-10-13 21:48 ` Vivek Goyal 0 siblings, 1 reply; 8+ messages in thread From: Vivek Goyal @ 2016-10-13 21:39 UTC (permalink / raw) To: CAI Qian; +Cc: Andreas Gruenbacher, Al Viro, Miklos Szeredi, linux-fsdevel On Thu, Oct 13, 2016 at 05:16:11PM -0400, Vivek Goyal wrote: > On Thu, Oct 13, 2016 at 04:38:23PM -0400, CAI Qian wrote: > > > > > > ----- Original Message ----- > > > From: "CAI Qian" <caiqian@redhat.com> > > > Sent: Wednesday, October 12, 2016 9:54:52 AM > > > Subject: docker overlay support broken post v4.8 > > > > > > Some patches went into the 4.9 merge window broke docker overlay support even > > > with > > > selinux disabled (setenforce 0). > > > > > > # docker run -it fedora bash > > > /usr/bin/docker-latest: Error response from daemon: error creating overlay > > > mount to > > > /var/lib/docker-latest/overlay/8ffc75b527de2863daef50a7c88a382b84953a0d40f49c40d2a9f504d9e8123c-init/merged: > > > operation not supported. > > > See '/usr/bin/docker-latest run --help'. > > > > > > This message splits in the console. > > > [61250.857832] SELinux: (dev overlay, type overlay) has no xattr support > > Reverted the patchset of "Xattr inode operation removal" against the latest mainline > > fixed the problem, i.e., commits below in order. > > > > fd50ecaddf8372a1d96e0daeaac0f93cf04e4d42 > > 6c6ef9f26e598fb977f60935e109cd5b266c941a > > bf3ee71363c0b44acb62f375aea470262ac4210a > > 5d6c31910bc0713e37628dc0ce677dcb13c8ccf4 > > f5c244383725a6de06bc62fa7c54c0ea0d942eec > > 5f6e59ae8277cef221fdbf9b12f0c4f80db59944 > > d0a5b995a308347fdb1bb0412df32acd0312523b > > Looking at selinux code, it seems to be coming from following code. > Looks like in case of overlay inode, we are not setting > IOP_XATTR? > > Vivek > > sb_finish_set_opts() > > if (sbsec->behavior == SECURITY_FS_USE_XATTR) { > /* Make sure that the xattr handler exists and that no > error other than -ENODATA is returned by getxattr on > the root directory. -ENODATA is ok, as this may be > the first boot of the SELinux kernel before we have > assigned xattr values to the filesystem. */ > if (!(root_inode->i_opflags & IOP_XATTR)) { > printk(KERN_WARNING "SELinux: (dev %s, type %s) has no " > "xattr support\n", sb->s_id, sb->s_type->name); > rc = -EOPNOTSUPP; > goto out; IOP_XATTR is set, if sb->s_xattr is not NULL. inode_init_always() { if (sb->s_xattr) inode->i_opflags |= IOP_XATTR; } In case of overlay, when preparing super block and root dentry, sb->s_xattr has not been set yet and we call, ovl_new_inode() new_inode() alloc_inode() inode_init_always() Looks like we need to initalize overlay super block little more and set s_xattr before calling ovl_new_inode(). Vivek ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [bisected] Re: docker overlay support broken post v4.8 2016-10-13 21:39 ` Vivek Goyal @ 2016-10-13 21:48 ` Vivek Goyal 2016-10-14 1:08 ` Andreas Grünbacher 0 siblings, 1 reply; 8+ messages in thread From: Vivek Goyal @ 2016-10-13 21:48 UTC (permalink / raw) To: CAI Qian; +Cc: Andreas Gruenbacher, Al Viro, Miklos Szeredi, linux-fsdevel On Thu, Oct 13, 2016 at 05:39:37PM -0400, Vivek Goyal wrote: [..] > > > > This message splits in the console. > > > > [61250.857832] SELinux: (dev overlay, type overlay) has no xattr support > > > Reverted the patchset of "Xattr inode operation removal" against the latest mainline > > > fixed the problem, i.e., commits below in order. > > > > > > fd50ecaddf8372a1d96e0daeaac0f93cf04e4d42 > > > 6c6ef9f26e598fb977f60935e109cd5b266c941a > > > bf3ee71363c0b44acb62f375aea470262ac4210a > > > 5d6c31910bc0713e37628dc0ce677dcb13c8ccf4 > > > f5c244383725a6de06bc62fa7c54c0ea0d942eec > > > 5f6e59ae8277cef221fdbf9b12f0c4f80db59944 > > > d0a5b995a308347fdb1bb0412df32acd0312523b > > > > Looking at selinux code, it seems to be coming from following code. > > Looks like in case of overlay inode, we are not setting > > IOP_XATTR? > > > > Vivek > > > > sb_finish_set_opts() > > > > if (sbsec->behavior == SECURITY_FS_USE_XATTR) { > > /* Make sure that the xattr handler exists and that no > > error other than -ENODATA is returned by getxattr on > > the root directory. -ENODATA is ok, as this may be > > the first boot of the SELinux kernel before we have > > assigned xattr values to the filesystem. */ > > if (!(root_inode->i_opflags & IOP_XATTR)) { > > printk(KERN_WARNING "SELinux: (dev %s, type %s) has no " > > "xattr support\n", sb->s_id, sb->s_type->name); > > rc = -EOPNOTSUPP; > > goto out; > > IOP_XATTR is set, if sb->s_xattr is not NULL. > > inode_init_always() { > if (sb->s_xattr) > inode->i_opflags |= IOP_XATTR; > } > > In case of overlay, when preparing super block and root dentry, > sb->s_xattr has not been set yet and we call, > > ovl_new_inode() > new_inode() > alloc_inode() > inode_init_always() > > Looks like we need to initalize overlay super block little more and > set s_xattr before calling ovl_new_inode(). Following hack fix seems to fix the issue for me. --- fs/overlayfs/super.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Index: rhvgoyal-linux/fs/overlayfs/super.c =================================================================== --- rhvgoyal-linux.orig/fs/overlayfs/super.c 2016-10-12 15:59:16.197781805 -0400 +++ rhvgoyal-linux/fs/overlayfs/super.c 2016-10-13 17:42:28.207365951 -0400 @@ -1292,6 +1292,9 @@ static int ovl_fill_super(struct super_b if (!oe) goto out_put_cred; + + sb->s_xattr = ovl_xattr_handlers; + root_dentry = d_make_root(ovl_new_inode(sb, S_IFDIR)); if (!root_dentry) goto out_free_oe; @@ -1317,7 +1320,6 @@ static int ovl_fill_super(struct super_b sb->s_magic = OVERLAYFS_SUPER_MAGIC; sb->s_op = &ovl_super_operations; - sb->s_xattr = ovl_xattr_handlers; sb->s_root = root_dentry; sb->s_fs_info = ufs; sb->s_flags |= MS_POSIXACL | MS_NOREMOTELOCK; ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [bisected] Re: docker overlay support broken post v4.8 2016-10-13 21:48 ` Vivek Goyal @ 2016-10-14 1:08 ` Andreas Grünbacher 0 siblings, 0 replies; 8+ messages in thread From: Andreas Grünbacher @ 2016-10-14 1:08 UTC (permalink / raw) To: Vivek Goyal, Al Viro, Miklos Szeredi Cc: CAI Qian, Andreas Gruenbacher, linux-fsdevel 2016-10-13 23:48 GMT+02:00 Vivek Goyal <vgoyal@redhat.com>: > On Thu, Oct 13, 2016 at 05:39:37PM -0400, Vivek Goyal wrote: > [..] >> > > > This message splits in the console. >> > > > [61250.857832] SELinux: (dev overlay, type overlay) has no xattr support >> > > Reverted the patchset of "Xattr inode operation removal" against the latest mainline >> > > fixed the problem, i.e., commits below in order. >> > > >> > > fd50ecaddf8372a1d96e0daeaac0f93cf04e4d42 >> > > 6c6ef9f26e598fb977f60935e109cd5b266c941a >> > > bf3ee71363c0b44acb62f375aea470262ac4210a >> > > 5d6c31910bc0713e37628dc0ce677dcb13c8ccf4 >> > > f5c244383725a6de06bc62fa7c54c0ea0d942eec >> > > 5f6e59ae8277cef221fdbf9b12f0c4f80db59944 >> > > d0a5b995a308347fdb1bb0412df32acd0312523b >> > >> > Looking at selinux code, it seems to be coming from following code. >> > Looks like in case of overlay inode, we are not setting >> > IOP_XATTR? >> > >> > Vivek >> > >> > sb_finish_set_opts() >> > >> > if (sbsec->behavior == SECURITY_FS_USE_XATTR) { >> > /* Make sure that the xattr handler exists and that no >> > error other than -ENODATA is returned by getxattr on >> > the root directory. -ENODATA is ok, as this may be >> > the first boot of the SELinux kernel before we have >> > assigned xattr values to the filesystem. */ >> > if (!(root_inode->i_opflags & IOP_XATTR)) { >> > printk(KERN_WARNING "SELinux: (dev %s, type %s) has no " >> > "xattr support\n", sb->s_id, sb->s_type->name); >> > rc = -EOPNOTSUPP; >> > goto out; >> >> IOP_XATTR is set, if sb->s_xattr is not NULL. >> >> inode_init_always() { >> if (sb->s_xattr) >> inode->i_opflags |= IOP_XATTR; >> } >> >> In case of overlay, when preparing super block and root dentry, >> sb->s_xattr has not been set yet and we call, >> >> ovl_new_inode() >> new_inode() >> alloc_inode() >> inode_init_always() >> >> Looks like we need to initalize overlay super block little more and >> set s_xattr before calling ovl_new_inode(). > > Following hack fix seems to fix the issue for me. This looks correct. I've sent a cleaned up version with a description for this (Message-Id: <1476407016-4993-1-git-send-email-agruenba@redhat.com>) which should be ready to apply unless Al or Miklos objects. Thanks, Andreas ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-10-14 1:08 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1844859631.492693.1476279971647.JavaMail.zimbra@redhat.com>
2016-10-12 13:54 ` docker overlay support broken post v4.8 CAI Qian
2016-10-13 20:38 ` [bisected] " CAI Qian
2016-10-13 20:40 ` Al Viro
2016-10-13 20:46 ` CAI Qian
2016-10-13 21:16 ` Vivek Goyal
2016-10-13 21:39 ` Vivek Goyal
2016-10-13 21:48 ` Vivek Goyal
2016-10-14 1:08 ` Andreas Grünbacher
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).