From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: linux-next: build failure after merge of the vfs tree Date: Wed, 4 Jan 2012 13:47:46 -0500 Message-ID: <20120104184746.GA8461@infradead.org> References: <20120103124331.f0f0043f8ca464c9ff13f4d3@canb.auug.org.au> <20120103133942.GC31457@quack.suse.cz> <20120103144531.GA23916@ZenIV.linux.org.uk> <20120104021754.GD23916@ZenIV.linux.org.uk> <20120104025020.GW23662@dastard> <20120104180033.GE28907@quack.suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Dave Chinner , Al Viro , Stephen Rothwell , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Mikulas Patocka , Linus Torvalds To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <20120104180033.GE28907@quack.suse.cz> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Wed, Jan 04, 2012 at 07:00:33PM +0100, Jan Kara wrote: > On Wed 04-01-12 13:50:20, Dave Chinner wrote: > > On Wed, Jan 04, 2012 at 02:17:54AM +0000, Al Viro wrote: > > > I'm still not > > > sure about ->statfs(), BTW - any input on that would be welcome. Can > > > it end up blocked on a frozen fs until said fs is thawed? > > > > I don't see why this should ever happen - ->statfs has to work on > > read-only filesystems so shoul dnot be modifying state, and hence > > should never need to care about the frozen state of the superblock. > Well, I'm also not aware of a filesystem where ->statfs would wait on > frozen filesystem. Just note that e.g. for stat(2) frozen filesystem and > RO filesystem *are* different because of atime updates. So stat(2) can > block on frozen fs because of atime update while on RO filesystem it is > just fine. Neither of those should cause atime updates.