linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Chris Mason <chris.mason@oracle.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org, axboe@kernel.dk
Subject: Re: [PATCH 0/2] Improvements for barrier-test scheduler
Date: Tue, 10 Jan 2012 20:22:27 -0500	[thread overview]
Message-ID: <20120111012227.GB2179@shiny> (raw)
In-Reply-To: <1326242647-23773-1-git-send-email-jack@suse.cz>

On Wed, Jan 11, 2012 at 01:44:05AM +0100, Jan Kara wrote:
> 
>   Hello Chris,
> 
>   I was hunting one ext3/4 barrier related bug and so I used your barrier-test
> IO scheduler. It was quite helpful so thank you for it. For my purposes, I
> had to tweak it a bit to trigger my problem. I'm not sure if you keep the
> scheduler somewhere but if yes, I hope my patches could be of use.
> 
> Patch 1 implements raw support for handling reads - we don't have to flush
> our delayed writes everytime a read comes. It is enough to do so when some
> delayed write overlaps with a read. Scanning the list of delayed writes is slow
> but who really cares for barrier-test :)

Perfect ;)

> 
> Patch 2 implements another criteria for reordering requests and triggering
> reboot. Filesystem can flag certain bios as special. These bios will go
> directly to the backing storage and when they complete, reboot is triggered
> if there are enough pending writes. Filesystem can use the flag when writing
> commit blocks, superblocks or similarly sensitive metadata to verify whether
> barriers are issued in all the necessary places.

Great idea, I'll fold this in.

Jens, is this something you want in 3.3, or would you like to let it
cook for another release cycle?

-chris

  parent reply	other threads:[~2012-01-11  1:22 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11  0:44 [PATCH 0/2] Improvements for barrier-test scheduler Jan Kara
2012-01-11  0:44 ` [PATCH 1/2] barrier-test: Do not flush delayed queue for reads Jan Kara
2012-01-11  0:44 ` [PATCH 2/2] barrier-test: Allow filesystem to specify special test request Jan Kara
2012-01-11  1:22 ` Chris Mason [this message]
2012-01-11 19:26   ` [PATCH 0/2] Improvements for barrier-test scheduler Jens Axboe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120111012227.GB2179@shiny \
    --to=chris.mason@oracle.com \
    --cc=axboe@kernel.dk \
    --cc=jack@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).