linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Sage Weil <sage@newdream.net>
Cc: viro@ZenIV.linux.org.uk, hch@infradead.org,
	ceph-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 1/2] vfs: export symbol d_find_any_alias()
Date: Wed, 11 Jan 2012 13:55:57 -0500	[thread overview]
Message-ID: <20120111185557.GA29582@infradead.org> (raw)
In-Reply-To: <1326307602-16284-2-git-send-email-sage@newdream.net>

On Wed, Jan 11, 2012 at 10:46:41AM -0800, Sage Weil wrote:
> Ceph needs this.
> 
> Signed-off-by: Sage Weil <sage@newdream.net>

Can you add a kerneldoc comment now that it is exported?

> -static struct dentry * d_find_any_alias(struct inode *inode)
> +struct dentry * d_find_any_alias(struct inode *inode)

also if you touch the line anyway please remove the superflous
whitespace after the '*'.


  reply	other threads:[~2012-01-11 18:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-11 18:46 [PATCH 0/2] Reenable ceph dcache usage Sage Weil
2012-01-11 18:46 ` [PATCH 1/2] vfs: export symbol d_find_any_alias() Sage Weil
2012-01-11 18:55   ` Christoph Hellwig [this message]
2012-01-11 20:43     ` Sage Weil
2012-01-12 19:04       ` Christoph Hellwig
2012-01-11 18:46 ` [PATCH 2/2] ceph: enable/disable dentry complete flags via mount option Sage Weil
2012-01-11 19:00   ` Christoph Hellwig
2012-01-11 20:44     ` Sage Weil
2012-01-12 19:05       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120111185557.GA29582@infradead.org \
    --to=hch@infradead.org \
    --cc=ceph-devel@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=sage@newdream.net \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).