From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wu Fengguang Subject: Re: [PATCH 6/9] readahead: add /debug/readahead/stats Date: Sun, 29 Jan 2012 13:07:22 +0800 Message-ID: <20120129050722.GC26244@localhost> References: <20120127030524.854259561@intel.com> <20120127031327.159293683@intel.com> <20120127121551.acd256aa.akpm@linux-foundation.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Lameter , Andi Kleen , Ingo Molnar , Jens Axboe , Peter Zijlstra , Rik van Riel , Linux Memory Management List , linux-fsdevel@vger.kernel.org, LKML To: Andrew Morton Return-path: Content-Disposition: inline In-Reply-To: <20120127121551.acd256aa.akpm@linux-foundation.org> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Jan 27, 2012 at 12:15:51PM -0800, Andrew Morton wrote: > > The accounting code will be compiled in by default > > (CONFIG_READAHEAD_STATS=y), and will remain inactive by default. > > I agree with those choices. They effectively mean that the stats will > be a developer-only/debugger-only thing. So even if the atomic_inc() > costs are measurable during these develop/debug sessions, is anyone > likely to care? Sorry I have changed the default to CONFIG_READAHEAD_STATS=n to avoid bloating the kernel (and forgot to edit the changelog accordingly). I'm not sure how many people are going to check the readahead stats. Thanks, Fengguang -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org