From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH V2 2/2] hfsplus: Add an ioctl to bless files
Date: Mon, 6 Feb 2012 12:49:43 -0500
Message-ID: <20120206174943.GA14225@infradead.org>
References: <1328215191-4201-1-git-send-email-mjg@redhat.com>
 <1328215191-4201-2-git-send-email-mjg@redhat.com>
 <20120206173553.GB1135@infradead.org>
 <20120206174549.GA1655@srcf.ucam.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Christoph Hellwig <hch@infradead.org>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To: Matthew Garrett <mjg59@srcf.ucam.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
Content-Disposition: inline
In-Reply-To: <20120206174549.GA1655@srcf.ucam.org>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: linux-fsdevel.vger.kernel.org

On Mon, Feb 06, 2012 at 05:45:49PM +0000, Matthew Garrett wrote:
> On Mon, Feb 06, 2012 at 12:35:53PM -0500, Christoph Hellwig wrote:
> > +#define HFSPLUS_IOC_BLESS              _IO('f', 0x20)
> > 
> > I'd probably move this to fs.h and follow the numbering there,
> > otherwise we are bound to run into conflicts.
> 
> Ok. Any problem with leaving something filesystem specific in there?

Leaving it in hfsplus sounds fine, but I'd avoid using 'f' then just to
reduce the chance for overlap.

> >From the spec:
> 
> "finderInfo[0] contains the directory ID of the directory containing the 
> bootable system (for example, the System Folder in Mac OS 8 or 9, or 
> /System/Library/CoreServices in Mac OS X). It is zero if there is no 
> bootable system on the volume. This value is typically equal to either 
> finderInfo[3] or finderInfo[5]."
> 
> finderInfo[3] is the OS8/9 system folder, finderInfo[5] is the OS X one. 
> I'd guess it's just to indicate whether the boot media should default to 
> OS8/9 or OS X, but it's not entirely clear.

Care to add this explanation as a comment?