From: Damien Wyart <damien.wyart@free.fr>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Shaohua Li <shaohua.li@intel.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>, Jens Axboe <axboe@kernel.dk>
Subject: Re: [PATCH] block: remove plugging at buffered write time
Date: Thu, 9 Feb 2012 10:40:19 +0100 [thread overview]
Message-ID: <20120209094019.GA516@brouette> (raw)
In-Reply-To: <20120209092535.GA10272@brouette>
> > Done, thanks! Here is the updated patch with O_SYNC write fix.
> Got these errors with the updated patch on top of 3.3-rc3:
> fs/sync.c: In function 'vfs_fsync_range':
> fs/sync.c:167:18: error: storage size of 'plug' isn't known
> fs/sync.c:173:2: error: implicit declaration of function 'blk_start_plug' [-Werror=implicit-function-declaration]
> fs/sync.c:175:2: error: implicit declaration of function 'blk_finish_plug' [-Werror=implicit-function-declaration]
> fs/sync.c:167:18: warning: unused variable 'plug' [-Wunused-variable]
Adding a #include <linux/blkdev.h> at the top of fs/sync.c solved the
problem. Of course, this needs approval of a kernel developper before
being added to the patch and resubmitted because I know adding #includes
can have unwanted consequences sometimes or be seen as bloat...
--
Damien Wyart
next prev parent reply other threads:[~2012-02-09 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 11:01 [PATCH] block: remove plugging at buffered write time Wu Fengguang
2012-02-08 23:27 ` Dave Chinner
2012-02-09 8:02 ` Wu Fengguang
2012-02-09 18:06 ` Christoph Hellwig
2012-02-09 18:30 ` Chris Mason
2012-02-10 1:52 ` Wu Fengguang
2012-02-10 2:47 ` Wu Fengguang
2012-02-10 9:41 ` Jan Kara
2012-02-09 1:14 ` Shaohua Li
2012-02-09 8:07 ` Wu Fengguang
2012-02-09 9:25 ` Damien Wyart
2012-02-09 9:40 ` Damien Wyart [this message]
2012-02-09 9:49 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120209094019.GA516@brouette \
--to=damien.wyart@free.fr \
--cc=akpm@linux-foundation.org \
--cc=axboe@kernel.dk \
--cc=fengguang.wu@intel.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=shaohua.li@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).