From: Dave Chinner <david@fromorbit.com>
To: Jan Kara <jack@suse.cz>
Cc: Eric Sandeen <sandeen@sandeen.net>,
Al Viro <viro@ZenIV.linux.org.uk>,
linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
mpatocka@redhat.com
Subject: Re: [PATCH 1/2] vfs: Provide function to get superblock and wait for it to thaw
Date: Sat, 11 Feb 2012 10:16:33 +1100 [thread overview]
Message-ID: <20120210231633.GH12836@dastard> (raw)
In-Reply-To: <20120210094858.GC10509@quack.suse.cz>
On Fri, Feb 10, 2012 at 10:48:58AM +0100, Jan Kara wrote:
> On Thu 09-02-12 10:37:20, Eric Sandeen wrote:
> > would "wait_for_thaw" vs. "thaw" be any clearer? Nitpicky I guess but the
> > meaning of "thawed" isn't immediately clear here. If it's already thawed? If
> > we want to wait for it it to be thawed? You can figure it out from the callers
> > but maybe a comment or a different name might help. No big deal.
> How about "wait_thaw". That should be explicit enough...
IMO, wait_for_thaw is much easier to read (i.e. better english ;) and
hence the code documents itself better. There's no reason to skimp
on characters here - it's not a heavily used variable....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2012-02-10 23:16 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-07 22:37 [PATCH 0/2] Fix deadlock with suspend & quotas Jan Kara
2012-02-07 22:37 ` [PATCH 1/2] vfs: Provide function to get superblock and wait for it to thaw Jan Kara
2012-02-08 23:20 ` Dave Chinner
2012-02-08 23:27 ` Jan Kara
2012-02-08 23:47 ` Jan Kara
2012-02-09 16:37 ` Eric Sandeen
2012-02-09 23:14 ` Mikulas Patocka
2012-02-10 9:48 ` Jan Kara
2012-02-10 23:16 ` Dave Chinner [this message]
2012-02-07 22:37 ` [PATCH 2/2] quota: Fix deadlock with suspend and quotas Jan Kara
2012-02-09 16:46 ` Eric Sandeen
-- strict thread matches above, loose matches on Subject: below --
2012-02-10 10:02 [PATCH 0/2 v2] Fix deadlock with suspend & quotas Jan Kara
2012-02-10 10:03 ` [PATCH 1/2] vfs: Provide function to get superblock and wait for it to thaw Jan Kara
2012-02-12 21:13 ` Al Viro
2012-02-13 14:24 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120210231633.GH12836@dastard \
--to=david@fromorbit.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=sandeen@sandeen.net \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).