From mboxrd@z Thu Jan 1 00:00:00 1970 From: Al Viro Subject: Re: [PATCH]QNX6 filesystem (RO) driver Date: Wed, 15 Feb 2012 07:11:19 +0000 Message-ID: <20120215071119.GF23916@ZenIV.linux.org.uk> References: <4F29A37F.6070909@ontika.net> <20120212045629.GO23916@ZenIV.linux.org.uk> <4F3839CE.8040805@ontika.net> <20120212224358.GW23916@ZenIV.linux.org.uk> <4F3B1DD1.3000202@ontika.net> <20120215061012.GC23916@ZenIV.linux.org.uk> <20120215064728.GE23916@ZenIV.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org To: Kai Bankett Return-path: Received: from zeniv.linux.org.uk ([195.92.253.2]:55871 "EHLO ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751135Ab2BOHLV (ORCPT ); Wed, 15 Feb 2012 02:11:21 -0500 Content-Disposition: inline In-Reply-To: <20120215064728.GE23916@ZenIV.linux.org.uk> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Feb 15, 2012 at 06:47:28AM +0000, Al Viro wrote: > On Wed, Feb 15, 2012 at 06:10:12AM +0000, Al Viro wrote: > > [snip] > > OK, I've dumped something that compiles in #qnx6 in vfs.git; I don't promise > anything beyond that - consider that as slightly more elaborate variant of > the previous mail. At that stage I would definitely prefer to see fixes, > etc. *folded* into the patch before it gets merged, so do not treat that > branch as anything other than convenient (for me) way to post a series of > incrementals. > > Oh, and the final result will obviously need s-o-b by Kai + sane commit > message, etc. If you prefer to test on top of -stable, just copy d_make_root() from current mainline into fs/dcache.c and export it - that's the only dependency on the stuff from the last merge window. Or just open-code the sucker into your fill_super... One more thing - unless I'm misreading the code it looks like your ->sb becomes a dangling pointer once fill_super finishes and ->statfs() is dereferencing it...