From: Alexey Dobriyan <adobriyan@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
npiggin@kernel.dk
Subject: Re: [PATCH] dcache: faster dentry_cmp()
Date: Wed, 15 Feb 2012 11:16:34 +0300 [thread overview]
Message-ID: <20120215081634.GC3306@p183.telecom.by> (raw)
In-Reply-To: <m2ehtw7tsf.fsf@firstfloor.org>
On Tue, Feb 14, 2012 at 05:46:24PM -0800, Andi Kleen wrote:
> Alexey Dobriyan <adobriyan@gmail.com> writes:
>
> > 1) consistently use "unsigned int" for dentry name length,
> > 2) reuse subtraction result for return value, exact value doesn't matter
> > because function is only used in boolean context,
> > 3) use *p++ idiom for even better code.
>
> I'm sure there are even better ways to do the comparision using longer
> words, especially as we know the boundaries and alignment.
This requires terminating dentry names with 1-3 NULs.
Al, can we afford such beauty?
next prev parent reply other threads:[~2012-02-15 8:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 22:45 [PATCH] dcache: faster dentry_cmp() Alexey Dobriyan
2012-02-14 22:58 ` Al Viro
2012-02-15 8:14 ` Alexey Dobriyan
2012-02-15 1:41 ` Matthew Wilcox
2012-02-15 8:14 ` Alexey Dobriyan
2012-02-15 1:46 ` Andi Kleen
2012-02-15 8:16 ` Alexey Dobriyan [this message]
2012-02-15 11:19 ` Alexey Dobriyan
2012-02-15 20:20 ` Andi Kleen
2012-04-20 12:06 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215081634.GC3306@p183.telecom.by \
--to=adobriyan@gmail.com \
--cc=andi@firstfloor.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).