From: Andi Kleen <andi@firstfloor.org>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
viro@zeniv.linux.org.uk, linux-fsdevel@vger.kernel.org,
npiggin@kernel.dk
Subject: Re: [PATCH] dcache: faster dentry_cmp()
Date: Wed, 15 Feb 2012 21:20:53 +0100 [thread overview]
Message-ID: <20120215202053.GD22014@one.firstfloor.org> (raw)
In-Reply-To: <CACVxJT897B8boE4wLbKgSfRyP5kB7qLBh+SnyF=K0eVFw1-RfQ@mail.gmail.com>
> > This requires terminating dentry names with 1-3 NULs.
> > Al, can we afford such beauty?
>
> Hmm.
>
> At least, in link_path_walk(), there is no room to insert NULs.
We don't necessarily need to pad. It's enough to use the word compare
as a fast path.
Of course memcpy should do it already, but it may be inefficient for
small strings.
-Andi
>
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2012-02-15 20:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-14 22:45 [PATCH] dcache: faster dentry_cmp() Alexey Dobriyan
2012-02-14 22:58 ` Al Viro
2012-02-15 8:14 ` Alexey Dobriyan
2012-02-15 1:41 ` Matthew Wilcox
2012-02-15 8:14 ` Alexey Dobriyan
2012-02-15 1:46 ` Andi Kleen
2012-02-15 8:16 ` Alexey Dobriyan
2012-02-15 11:19 ` Alexey Dobriyan
2012-02-15 20:20 ` Andi Kleen [this message]
2012-04-20 12:06 ` Nick Piggin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120215202053.GD22014@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=adobriyan@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=npiggin@kernel.dk \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).