From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH] dcache: faster dentry_cmp()
Date: Wed, 15 Feb 2012 21:20:53 +0100
Message-ID: <20120215202053.GD22014@one.firstfloor.org>
References: <20120214224526.GA3478@p183.telecom.by> <m2ehtw7tsf.fsf@firstfloor.org> <20120215081634.GC3306@p183.telecom.by> <CACVxJT897B8boE4wLbKgSfRyP5kB7qLBh+SnyF=K0eVFw1-RfQ@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: Andi Kleen <andi@firstfloor.org>, viro@zeniv.linux.org.uk,
	linux-fsdevel@vger.kernel.org, npiggin@kernel.dk
To: Alexey Dobriyan <adobriyan@gmail.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from one.firstfloor.org ([213.235.205.2]:44346 "EHLO
	one.firstfloor.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753132Ab2BOUU4 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Wed, 15 Feb 2012 15:20:56 -0500
Content-Disposition: inline
In-Reply-To: <CACVxJT897B8boE4wLbKgSfRyP5kB7qLBh+SnyF=K0eVFw1-RfQ@mail.gmail.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

> > This requires terminating dentry names with 1-3 NULs.
> > Al, can we afford such beauty?
> 
> Hmm.
> 
> At least, in link_path_walk(), there is no room to insert NULs.

We don't necessarily need to pad. It's enough to use the word compare
as a fast path.

Of course memcpy should do it already, but it may be inefficient for
small strings.

-Andi
> 

-- 
ak@linux.intel.com -- Speaking for myself only.