From: Al Viro <viro@ZenIV.linux.org.uk>
To: Kai Bankett <chaosman@ontika.net>
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH]QNX6 filesystem (RO) driver
Date: Thu, 16 Feb 2012 10:00:43 +0000 [thread overview]
Message-ID: <20120216100043.GJ23916@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20120215144037.GH23916@ZenIV.linux.org.uk>
On Wed, Feb 15, 2012 at 02:40:37PM +0000, Al Viro wrote:
> Other than that... this stuff could use some tidying up, but that's not
> a big deal. I really wonder if these config options are worthwhile -
> might be better to stick endianness and mmi to y unconditionally. And
> of course all those incrementals are completely untested and might very
> well br broken.
FWIW, having looked at that code again, I'm definitely in favour of dumping
the ENDIANNESS and MMI config options; the latter is not time-critical at all
(of anything even remotely hot it only affects the checksum verification
for longnames on readdir *and* its only effect is possible short-circuiting
a relatively long calculation - I've just spotted and fixed a braino in
that ifdef from hell, BTW). And the former... I would be _very_ surprised
if disabling it would be a visible win on any workloads.
BTW, reporting non-options in ->show_options() is probably a bad idea;
sure, you end up ignoring options in your ->mount(), so it won't confuse
any userland scripts too badly, but...
next prev parent reply other threads:[~2012-02-16 10:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-01 20:41 [PATCH]QNX6 filesystem (RO) driver Kai Bankett
2012-02-12 4:56 ` Al Viro
2012-02-12 22:14 ` Kai Bankett
2012-02-12 22:43 ` Al Viro
2012-02-15 2:52 ` Kai Bankett
2012-02-15 6:10 ` Al Viro
2012-02-15 6:14 ` Al Viro
2012-02-15 6:47 ` Al Viro
2012-02-15 7:11 ` Al Viro
2012-02-15 7:57 ` Al Viro
2012-02-15 14:40 ` Al Viro
2012-02-15 16:27 ` Kai Bankett
2012-02-15 21:35 ` Al Viro
2012-02-16 10:00 ` Al Viro [this message]
2012-02-17 15:06 ` Kai Bankett
2012-02-17 16:20 ` Al Viro
2012-02-17 17:53 ` Kai Bankett
2012-02-17 18:35 ` Al Viro
2012-02-17 18:53 ` Al Viro
2012-02-17 21:38 ` Kai Bankett
2012-02-21 22:04 ` Al Viro
2012-02-21 22:09 ` Al Viro
2012-02-22 11:58 ` Kai Bankett
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120216100043.GJ23916@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=chaosman@ontika.net \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).