From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ram Pai Subject: Re: [PATCH 09/73] VFS: Add CL_NO_SLAVE flag to clone_mnt()/copy_tree() [ver #2] Date: Wed, 29 Feb 2012 14:58:08 +0800 Message-ID: <20120229065808.GC5030@ram-ThinkPad-T61> References: <20120221175721.25235.8901.stgit@warthog.procyon.org.uk> <20120221175832.25235.96909.stgit@warthog.procyon.org.uk> Reply-To: Ram Pai Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org, viro@ZenIV.linux.org.uk, valerie.aurora@gmail.com, linux-kernel@vger.kernel.org To: David Howells Return-path: Content-Disposition: inline In-Reply-To: <20120221175832.25235.96909.stgit@warthog.procyon.org.uk> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Feb 21, 2012 at 05:58:32PM +0000, David Howells wrote: > From: Valerie Aurora > > Passing the CL_NO_SLAVE flag to clone_mnt() causes the clone > to fail if the source mnt is a slave. > > Original-author: Valerie Aurora > Signed-off-by: David Howells > Cc: Ram Pai Reviewed-by: Ram Pai > --- > > fs/namespace.c | 3 +++ > fs/pnode.h | 1 + > 2 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/fs/namespace.c b/fs/namespace.c > index f92f574..96f43f2 100644 > --- a/fs/namespace.c > +++ b/fs/namespace.c > @@ -743,6 +743,9 @@ static struct mount *clone_mnt(struct mount *old, struct dentry *root, > if ((flag & CL_NO_SHARED) && IS_MNT_SHARED(old)) > return ERR_PTR(-EINVAL); > > + if ((flag & CL_NO_SLAVE) && IS_MNT_SLAVE(old)) > + return ERR_PTR(-EINVAL); > + > mnt = alloc_vfsmnt(old->mnt_devname); > if (!mnt) > return ERR_PTR(-ENOMEM); > diff --git a/fs/pnode.h b/fs/pnode.h > index c7089dd..f7ae149 100644 > --- a/fs/pnode.h > +++ b/fs/pnode.h > @@ -23,6 +23,7 @@ > #define CL_MAKE_SHARED 0x08 > #define CL_PRIVATE 0x10 > #define CL_NO_SHARED 0x20 > +#define CL_NO_SLAVE 0x40 > > static inline void set_mnt_shared(struct mount *mnt) > {