From: Oleg Nesterov <oleg@redhat.com>
To: Ben Chan <benchan@chromium.org>
Cc: linux-kernel@vger.kernel.org,
Alexander Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] exec: abort core dump piping only due to a fatal signal
Date: Thu, 1 Mar 2012 20:03:22 +0100 [thread overview]
Message-ID: <20120301190322.GA9638@redhat.com> (raw)
In-Reply-To: <1330626227-32257-1-git-send-email-benchan@chromium.org>
On 03/01, Ben Chan wrote:
>
> This patch makes wait_for_dump_helpers() not to abort piping the core
> dump data when the crashing process has received any but a fatal signal
> (SIGKILL). The rationale is that a crashing process may still receive
> uninteresting signals such as SIGCHLD when its core dump data is being
> redirected to a helper application. While it's necessary to allow
> terminating the core dump piping via SIGKILL,
Noe that SIGKILL doesn't really work. IOW, there are more problems.
> it's practically more
> useful for the purpose of debugging and crash reporting if the core dump
> piping is not aborted due to other non-fatal signals.
Yes.
> Addresses http://code.google.com/p/chromium-os/issues/detail?id=21559
Heh. please look at https://bugzilla.redhat.com/show_bug.cgi?id=759213
> @@ -2031,7 +2031,7 @@ static void wait_for_dump_helpers(struct file *file)
> pipe->readers++;
> pipe->writers--;
>
> - while ((pipe->readers > 1) && (!signal_pending(current))) {
> + while ((pipe->readers > 1) && (!fatal_signal_pending(current))) {
No, it is not that simple. This can't fix all problems and in fact
this check should be simply removed (but not right now).
Oh. I'll try to send the fix, well, soon. The problem is that I
already promised this before ;)
See also http://marc.info/?l=linux-kernel&m=131989970411759
Oleg.
prev parent reply other threads:[~2012-03-01 19:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-01 18:23 [PATCH] exec: abort core dump piping only due to a fatal signal Ben Chan
2012-03-01 19:03 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120301190322.GA9638@redhat.com \
--to=oleg@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=benchan@chromium.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).