linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: Jeff Moyer <jmoyer@redhat.com>
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
Subject: Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC
Date: Sat, 3 Mar 2012 04:33:32 -0500	[thread overview]
Message-ID: <20120303093332.GA8417@infradead.org> (raw)
In-Reply-To: <x49ipim7r19.fsf@segfault.boston.devel.redhat.com>

On Fri, Mar 02, 2012 at 02:15:46PM -0500, Jeff Moyer wrote:
> Hi,
> 
> This patch adds a couple more aio-stress runs to test 113.  The first
> simply adds -S, to test out AIO+DIO+O_SYNC.  The second adds -S and -o
> 2, which directs aio-stress to only perform the random write test.
> These two tests helped identify several bugs in ext4.

I'd rather make this a separate testcase, maybe moving the _do_test into
common code.

Rationale:  newly added tests shouldn't make old testcases fail, as that
would be rather confusing.


  parent reply	other threads:[~2012-03-03  9:33 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-02 19:15 [xfstests patch] 113: add testing for O_DIRECT + O_SYNC Jeff Moyer
2012-03-02 20:15 ` Eric Sandeen
2012-03-03  9:33 ` Christoph Hellwig [this message]
2012-03-03 19:03   ` Eric Sandeen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20120303093332.GA8417@infradead.org \
    --to=hch@infradead.org \
    --cc=jmoyer@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).