From mboxrd@z Thu Jan  1 00:00:00 1970
From: Christoph Hellwig <hch@infradead.org>
Subject: Re: [xfstests patch] 113: add testing for O_DIRECT + O_SYNC
Date: Sat, 3 Mar 2012 04:33:32 -0500
Message-ID: <20120303093332.GA8417@infradead.org>
References: <x49ipim7r19.fsf@segfault.boston.devel.redhat.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org
To: Jeff Moyer <jmoyer@redhat.com>
Return-path: <linux-fsdevel-owner@vger.kernel.org>
Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:48863
	"EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S1751308Ab2CCJde (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Sat, 3 Mar 2012 04:33:34 -0500
Content-Disposition: inline
In-Reply-To: <x49ipim7r19.fsf@segfault.boston.devel.redhat.com>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Fri, Mar 02, 2012 at 02:15:46PM -0500, Jeff Moyer wrote:
> Hi,
> 
> This patch adds a couple more aio-stress runs to test 113.  The first
> simply adds -S, to test out AIO+DIO+O_SYNC.  The second adds -S and -o
> 2, which directs aio-stress to only perform the random write test.
> These two tests helped identify several bugs in ext4.

I'd rather make this a separate testcase, maybe moving the _do_test into
common code.

Rationale:  newly added tests shouldn't make old testcases fail, as that
would be rather confusing.