From: Christoph Hellwig <hch@infradead.org>
To: Saugata Das <saugata.das@stericsson.com>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
saugata.das@linaro.org, arnd.bergmann@linaro.org, tytso@mit.edu,
adilger@whamcloud.com, venkat@linaro.org
Subject: Re: [PATCH v2] REQ_META set during meta data write
Date: Sat, 3 Mar 2012 04:34:41 -0500 [thread overview]
Message-ID: <20120303093441.GB8417@infradead.org> (raw)
In-Reply-To: <1330692309-6187-1-git-send-email-saugata.das@stericsson.com>
On Fri, Mar 02, 2012 at 06:15:09PM +0530, Saugata Das wrote:
> --- a/fs/buffer.c
> +++ b/fs/buffer.c
> @@ -2926,6 +2926,9 @@ int submit_bh(int rw, struct buffer_head * bh)
> if (test_set_buffer_req(bh) && (rw & WRITE))
> clear_buffer_write_io_error(bh);
>
> + if (buffer_meta(bh))
> + rw |= REQ_META;
> +
submit_bh has a perfectly valid rw argument where you can pass REQ_META.
Please use that instead of abusing a buffer state bit for an I/O
submission flag.
next prev parent reply other threads:[~2012-03-03 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 12:45 [PATCH v2] REQ_META set during meta data write Saugata Das
2012-03-03 9:34 ` Christoph Hellwig [this message]
2012-03-04 8:02 ` Saugata Das
2012-03-22 11:08 ` Saugata Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120303093441.GB8417@infradead.org \
--to=hch@infradead.org \
--cc=adilger@whamcloud.com \
--cc=arnd.bergmann@linaro.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=saugata.das@linaro.org \
--cc=saugata.das@stericsson.com \
--cc=tytso@mit.edu \
--cc=venkat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).