From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 7/9] vfs: reorganize do_lookup Date: Tue, 13 Mar 2012 05:34:45 -0400 Message-ID: <20120313093445.GB11797@infradead.org> References: <1331038601-20353-1-git-send-email-miklos@szeredi.hu> <1331038601-20353-8-git-send-email-miklos@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, mszeredi@suse.cz To: Miklos Szeredi Return-path: Content-Disposition: inline In-Reply-To: <1331038601-20353-8-git-send-email-miklos@szeredi.hu> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org > + /* > + * Don't bother with __d_lookup: callers are for creat as > + * well as unlink, so a lot of the time it would cost > + * a double lookup. > + */ > + dentry = d_lookup(base, name); This comment isn't true anymore now, although the actual code should still be fine given that we already did the __d_lookup before for regular lookups.