From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 00/25] vfs: atomic open RFC Date: Tue, 13 Mar 2012 05:51:02 -0400 Message-ID: <20120313095102.GA27480@infradead.org> References: <1331155362-11132-1-git-send-email-miklos@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, Trond.Myklebust@netapp.com, sfrench@samba.org, sage@newdream.net, ericvh@gmail.com, mszeredi@suse.cz To: Miklos Szeredi Return-path: Content-Disposition: inline In-Reply-To: <1331155362-11132-1-git-send-email-miklos@szeredi.hu> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org Do we really need the opendata structure? It seems like we could just pass a struct path instead of the dentry passed directly and the vfsmount in it. There should be no need to preallocate the file before calling into ->atomic_open, as it's only used to pass around f_flags - but we already pass that one to ->atomic_open directly and might as well pass it on to finish_open and allocate the file there.