From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 06/25] vfs: add i_op->atomic_create() Date: Tue, 13 Mar 2012 07:55:52 -0400 Message-ID: <20120313115552.GA21043@infradead.org> References: <1331155362-11132-1-git-send-email-miklos@szeredi.hu> <1331155362-11132-7-git-send-email-miklos@szeredi.hu> <20120313093720.GC11797@infradead.org> <87lin49259.fsf@tucsk.pomaz.szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Christoph Hellwig , viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Trond.Myklebust@netapp.com, sfrench@samba.org, sage@newdream.net, ericvh@gmail.com To: Miklos Szeredi Return-path: Content-Disposition: inline In-Reply-To: <87lin49259.fsf@tucsk.pomaz.szeredi.hu> Sender: linux-kernel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org On Tue, Mar 13, 2012 at 12:22:10PM +0100, Miklos Szeredi wrote: > Good point. Yes, ->create is probably worth getting rid of. Mkdir, I'm > not so sure, but I'll look at what filesystems are doing. Btw, is there any good reason to keep ->atomic_open and ->atomic_create separate? It seems like the instances in general share code anyway.