From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 13/25] cifs: implement i_op->atomic_open() and i_op->atomic_create() Date: Tue, 13 Mar 2012 08:06:49 -0400 Message-ID: <20120313120649.GB27171@infradead.org> References: <1331155362-11132-1-git-send-email-miklos@szeredi.hu> <1331155362-11132-14-git-send-email-miklos@szeredi.hu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: viro@ZenIV.linux.org.uk, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, hch@infradead.org, Trond.Myklebust@netapp.com, sfrench@samba.org, sage@newdream.net, ericvh@gmail.com, mszeredi@suse.cz To: Miklos Szeredi Return-path: Received: from 173-166-109-252-newengland.hfc.comcastbusiness.net ([173.166.109.252]:49411 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755461Ab2CMMGw (ORCPT ); Tue, 13 Mar 2012 08:06:52 -0400 Content-Disposition: inline In-Reply-To: <1331155362-11132-14-git-send-email-miklos@szeredi.hu> Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On Wed, Mar 07, 2012 at 10:22:30PM +0100, Miklos Szeredi wrote: > From: Miklos Szeredi > > Replace CIFS's ->create operation with ->atomic_open and ->atomic_create. Also > move the relevant code from ->lookup into the create function. > > CIFS currently only does atomic open for O_CREAT, but it wants to do that as > early as possible, without first calling ->lookup, so it uses ->atomic_open, > just like NFS. Why does cifs need to set the created flag from inside ->atomic_open? It's different from everyone else in that respect.