From: Fengguang Wu <fengguang.wu@intel.com>
To: Jan Kara <jack@suse.cz>
Cc: linux-fsdevel@vger.kernel.org,
LKML <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH 0/4] Get rid of iput() from flusher thread
Date: Mon, 19 Mar 2012 13:16:36 +0800 [thread overview]
Message-ID: <20120319051636.GB5191@localhost> (raw)
In-Reply-To: <1331283748-12959-1-git-send-email-jack@suse.cz>
On Fri, Mar 09, 2012 at 10:02:24AM +0100, Jan Kara wrote:
>
> Hi,
>
> this patch set changes writeback_sb_inodes() to avoid iput() which might
> be problematic (see patch 4 which tries to summarize our email discussions)
> for some filesystems.
>
> Patches 1 and 2 are trivial mostly unrelated fixes (Fengguang, can you can
> take these and merge them right away please?).
Sure, they have been tested in linux-next for some days.
> Patch 3 is a preparatory code
> reshuffle and patch 4 removes the __iget() / iput() from flusher thread.
These are pretty sane changes towards the right direction (in despite
of the complexities involved).
> As a side note, your patches to offload writeback from kswapd to flusher
> thread then won't need iget/iput either if we pass page references as we talked
> so that should resolve most of the concerns.
>
> What do you think guys?
I appreciate the work a lot. Thank you for removing the major problem
with the patches on pageout writeback work :-)
Regards,
Fengguang
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
prev parent reply other threads:[~2012-03-19 5:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 9:02 [PATCH 0/4] Get rid of iput() from flusher thread Jan Kara
2012-03-09 9:02 ` [PATCH 1/4] fs: Remove bogus wait in write_inode_now() Jan Kara
2012-03-19 6:57 ` Christoph Hellwig
2012-03-09 9:02 ` [PATCH 2/4] writeback: Remove outdated comment Jan Kara
2012-03-19 6:58 ` Christoph Hellwig
2012-03-09 9:02 ` [PATCH 3/4] writeback: Refactor writeback_single_inode() Jan Kara
2012-03-19 5:07 ` Fengguang Wu
2012-03-19 7:13 ` Christoph Hellwig
2012-03-19 16:16 ` Jan Kara
2012-03-09 9:02 ` [PATCH 4/4] writeback: Avoid iput() from flusher thread Jan Kara
2012-03-19 3:42 ` Fengguang Wu
2012-03-19 8:55 ` Christoph Hellwig
2012-03-19 10:46 ` Jan Kara
2012-03-19 11:17 ` Fengguang Wu
2012-03-19 5:16 ` Fengguang Wu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120319051636.GB5191@localhost \
--to=fengguang.wu@intel.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).