From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/4] fs: Remove bogus wait in write_inode_now() Date: Mon, 19 Mar 2012 02:57:39 -0400 Message-ID: <20120319065739.GA11113@infradead.org> References: <1331283748-12959-1-git-send-email-jack@suse.cz> <1331283748-12959-2-git-send-email-jack@suse.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Wu Fengguang , linux-fsdevel@vger.kernel.org, LKML , linux-mm@kvack.org, Andrew Morton To: Jan Kara Return-path: Content-Disposition: inline In-Reply-To: <1331283748-12959-2-git-send-email-jack@suse.cz> Sender: owner-linux-mm@kvack.org List-Id: linux-fsdevel.vger.kernel.org On Fri, Mar 09, 2012 at 10:02:25AM +0100, Jan Kara wrote: > inode_sync_wait() in write_inode_now() is just bogus. That function waits for > I_SYNC bit to be cleared but writeback_single_inode() clears the bit on return > so the wait is effectivelly a nop unless someone else submits the inode for > writeback again. All the waiting write_inode_now() needs is achieved by using > WB_SYNC_ALL writeback mode. > > Signed-off-by: Jan Kara Loks good - I have the same in my patchkit to kill write_inode_now (which I really need to get out soon). Signed-off-by: Christoph Hellwig -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/ . Fight unfair telecom internet charges in Canada: sign http://stopthemeter.ca/ Don't email: email@kvack.org