From: "J. Bruce Fields" <bfields@fieldses.org>
To: Al Viro <viro@zeniv.linux.org.uk>
Cc: linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>
Subject: Re: [PATCH] vfs: take i_mutex on renamed file
Date: Tue, 20 Mar 2012 15:27:12 -0400 [thread overview]
Message-ID: <20120320192712.GA1431@fieldses.org> (raw)
In-Reply-To: <20120309222114.GA22423@fieldses.org>
On Fri, Mar 09, 2012 at 05:21:14PM -0500, J. Bruce Fields wrote:
> On Mon, Mar 05, 2012 at 05:43:34PM -0500, J. Bruce Fields wrote:
> > Al, do you see any reason this won't work?
> >
> > After this, all I need to make nfsd happy is a patch to locks.c to
> > implement delegations, and then a few one-liners to add break_deleg
> > calls in the right operations. So this is the one non-trivial change I
> > have to core vfs code.
> >
> > All of those patches are also ready, and I'd like to merge them for 3.4.
>
> By the way, the following is the rest of the series.
>
> (Compared to the last posting the deleg-breaking interface is
> simplified.)
What are the chances of getting this reviewed for this merge cycle? Is
it on somebody's list?
If it would make it any simpler: the one that I think absolutely must get wider
review, and get merged through Al's tree, is "vfs: take i_mutex on renamed
file".
There aren't actually any dependencies between that and the rest; and
the rest is mainly in nfsd/ and locks.c (changes to which have mostly
been going through my tree anyway, I think); other than that:
fs/attr.c | 3 ++
fs/namei.c | 18 +++++++++++++-
straightforward changes that tend to look like:
+ error = break_deleg(inode, O_WRONLY);
+ if (error)
+ return error;
include/linux/fs.h | 19 +++++++++++++--
and some definitions.
--b.
next prev parent reply other threads:[~2012-03-20 19:27 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-05 22:38 [PATCH] vfs: take i_mutex on renamed file J. Bruce Fields
2012-03-05 22:43 ` J. Bruce Fields
[not found] ` <20120305224334.GB16444-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-03-09 22:21 ` J. Bruce Fields
2012-03-09 22:29 ` [PATCH 1/7] " J. Bruce Fields
2012-03-09 22:29 ` [PATCH 2/7] locks: introduce new FL_DELEG lock flag J. Bruce Fields
2012-03-09 22:29 ` [PATCH 3/7] locks: implement delegations J. Bruce Fields
[not found] ` <20120309222114.GA22423-uC3wQj2KruNg9hUCZPvPmw@public.gmane.org>
2012-03-09 22:29 ` [PATCH 4/7] locks: break delegations on unlink J. Bruce Fields
2012-03-09 22:29 ` [PATCH 5/7] locks: break delegations on rename J. Bruce Fields
2012-03-09 22:29 ` [PATCH 6/7] locks: break delegations on link J. Bruce Fields
2012-03-09 22:29 ` [PATCH 7/7] locks: break delegations on any attribute modification J. Bruce Fields
2012-03-20 19:27 ` J. Bruce Fields [this message]
2012-04-10 13:07 ` [PATCH] vfs: take i_mutex on renamed file J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120320192712.GA1431@fieldses.org \
--to=bfields@fieldses.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).