From: Dave Jones <davej@redhat.com>
To: Brian Gerst <brgerst@gmail.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Jason Garrett-Glaser <jason@x264.com>,
Andi Kleen <andi@firstfloor.org>,
"H. Peter Anvin" <hpa@zytor.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: Word-at-a-time dcache name accesses (was Re: .. anybody know of any filesystems that depend on the exact VFS 'namehash' implementation?)
Date: Tue, 27 Mar 2012 01:02:38 -0400 [thread overview]
Message-ID: <20120327050238.GA19496@redhat.com> (raw)
In-Reply-To: <CAMzpN2hqay2h111C6pWw6VEBMLDfO_UF-Xf41M1x5ewp5K90yw@mail.gmail.com>
On Tue, Mar 27, 2012 at 12:42:19AM -0400, Brian Gerst wrote:
> > I did only very limited profiling of the 32-bit case, but it's really
> > just four cheap ALU instructions there and didn't really show up at
> > all in the limited profiles I did. And at least I checked that the
> > code worked. I have to say that the advantage of "vectorizing" this
> > code is obviously much less if you can only do 4-byte "vectors", so I
> > didn't actually time whether the patch *improves* anything on x86-32.
> >
>
> This patch is causing my system (x86-64, Fedora 16) to fail to boot
> when DEBUG_PAGEALLOC=n. No oops, but these error messages were in the
> log for the bad kernel:
I saw this too, it was fixed by f132c5be05e407a99cf582347a2ae0120acd3ad7 for me.
Does your kernel have that commit ?
Dave
next prev parent reply other threads:[~2012-03-27 5:02 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 23:46 Word-at-a-time dcache name accesses (was Re: .. anybody know of any filesystems that depend on the exact VFS 'namehash' implementation?) Linus Torvalds
2012-03-03 0:02 ` Ted Ts'o
2012-03-03 0:17 ` david
2012-03-03 0:24 ` Linus Torvalds
2012-03-04 22:19 ` Matthew Wilcox
2012-03-04 23:27 ` Linus Torvalds
2012-03-03 0:17 ` Linus Torvalds
2012-03-03 0:38 ` H. Peter Anvin
2012-03-03 0:57 ` Linus Torvalds
2012-03-03 1:02 ` H. Peter Anvin
2012-03-03 1:11 ` Linus Torvalds
2012-03-03 1:17 ` H. Peter Anvin
2012-03-03 16:12 ` Word-at-a-time dcache name accesses Andi Kleen
2012-03-03 18:47 ` H. Peter Anvin
2012-03-03 20:10 ` Word-at-a-time dcache name accesses (was Re: .. anybody know of any filesystems that depend on the exact VFS 'namehash' implementation?) Linus Torvalds
2012-03-04 2:27 ` Word-at-a-time dcache name accesses (was Re: .. anybody know ofany " Tetsuo Handa
2012-03-04 4:31 ` Andi Kleen
2012-03-05 3:58 ` Word-at-a-time dcache name accesses (was Re: .. anybody know of any " Jason Garrett-Glaser
2012-03-05 5:38 ` Linus Torvalds
2012-03-27 4:42 ` Brian Gerst
2012-03-27 5:02 ` Dave Jones [this message]
2012-03-27 5:31 ` Brian Gerst
2012-03-28 0:39 ` Linus Torvalds
2012-03-28 0:50 ` Linus Torvalds
2012-03-28 0:56 ` Brian Gerst
[not found] ` <CACvQF53YasSCUit2KoWDimgObknCz++aU90MesSfvAZTeUFQHw@mail.gmail.com>
2013-04-04 16:50 ` Lai Jiangshan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20120327050238.GA19496@redhat.com \
--to=davej@redhat.com \
--cc=andi@firstfloor.org \
--cc=brgerst@gmail.com \
--cc=hpa@zytor.com \
--cc=jason@x264.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).